Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc response decode failed with recent released version of tendermint #423

Closed
yihuang opened this issue Jul 9, 2020 · 1 comment · Fixed by #432
Closed

rpc response decode failed with recent released version of tendermint #423

yihuang opened this issue Jul 9, 2020 · 1 comment · Fixed by #432

Comments

@yihuang
Copy link
Contributor

yihuang commented Jul 9, 2020

Does it only works with tendermint git version?
I used the most recent released version(0.33.6), I got many null decoding issues, also the gasUsed -> gas_used/gasWanted -> gas_wanted naming differences.

An example block_results response:

{
  "begin_block_events":null,
  "consensus_param_updates":null,
  "end_block_events":[
    {
      "attributes":[
        {
          "key":"ZXRoYmxvb20=",
          "value":"AAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=="
        }
      ],
      "type":"block_filter"
    }
  ],
  "height":"4",
  "txs_results":[
    {
      "code":0,
      "codespace":"",
      "data":null,
      "events":[
        {
          "attributes":[
            {
              "key":"ZmVl",
              "value":"MC4wMDAwMDMwOA=="
            },
            {
              "key":"dHhpZA==",
              "value":"Y2UxYzc3NDIyM2Q2ZWNjMDQ4MWIxZTVkMjc2MmE4Njc0ZDhkODc2MjI2MjRlNTdlYmZiMzk4NTEzZmJhNDVmNg=="
            }
          ],
          "type":"valid_txs"
        },
        {
          "attributes":[
            {
              "key":"c3Rha2luZ19hZGRyZXNz",
              "value":"MHgzMzUwMmVkMzlkMGM0ZTIwNDRmYjM3ZmRjZDUxNjE0OTNmNTkwMGMz"
            },
            {
              "key":"c3Rha2luZ19vcHR5cGU=",
              "value":"d2l0aGRyYXc="
            },
            {
              "key":"c3Rha2luZ19kaWZm",
              "value":"W3sia2V5IjoiVW5ib25kZWQiLCJ2YWx1ZSI6Ii01MDAwMDAwMDAwMDAwMDAwMDAifV0="
            }
          ],
          "type":"staking_change"
        }
      ],
      "gasUsed":"0",
      "gasWanted":"0",
      "info":"",
      "log":""
    }
  ],
  "validator_updates":null
}

Compare to the one in unit test: https://github.com/informalsystems/tendermint-rs/blob/master/rpc/tests/support/block_results.json

@liamsi
Copy link
Member

liamsi commented Jul 11, 2020

We should update our CI image to the latest 0.33 release to guarantee we aren't missing any changes there. Currently, we are using 0.33.5:

image: tendermint/tendermint:v0.33.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants