Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on time 0.3.5 conflicts with requirements in ibc-rs dependency tree #1047

Closed
Tracked by #1043
mzabaluev opened this issue Dec 8, 2021 · 2 comments · Fixed by #1050
Closed
Tracked by #1043

Dependency on time 0.3.5 conflicts with requirements in ibc-rs dependency tree #1047

mzabaluev opened this issue Dec 8, 2021 · 2 comments · Fixed by #1050
Labels
bug Something isn't working critical dependencies Pull requests that update a dependency file ibc Required by IBC

Comments

@mzabaluev
Copy link
Contributor

Version(s) of tendermint-rs: v0.23.x branch pre 0.23.2

What went wrong?

Changes landed in #1036 break the build for ibc-rs because it requires rouille, which pins its dependency on time to =0.3.2: tomaka/rouille#246

De-facto tendermint now requires 0.3.5 though (which erroneously is not what Cargo.toml specifies) due to the API it uses.

Steps to reproduce

Uncomment the patch section in the ibc-rs project's top-level Cargo.toml, change the branch to v0.23.x and try to build.

Definition of "done"

The quickest fix is to remove any use of time API post 0.3.2 and make sure nothing in the project requires a higher version.
Luckily, only some non-essential additions currently require that, which can be undone. I'd like to keep the full API In master, though. ibc-rs would have time to address the dependency problems before switching to that.

@thanethomson
Copy link
Contributor

Can we close this now given that #1048's been merged? Or let me know once you've tested with ibc-rs and feel free to close this.

@mzabaluev
Copy link
Contributor Author

Still no cigar: I left a couple more checked_add/checked_sub uses in the code. Will fix in another PR.

@mzabaluev mzabaluev reopened this Dec 9, 2021
@mzabaluev mzabaluev linked a pull request Dec 9, 2021 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical dependencies Pull requests that update a dependency file ibc Required by IBC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants