Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add finalized_block_events in fetch_all_events #4262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kyoodong
Copy link

@kyoodong kyoodong commented Nov 29, 2024

Description

To collect events in finalize_block_events
Old version does not collect events in finalize_block_events before any ibc message is issued.
Here is the case

  • Transfer IBC in EndBlocker
  • Wait for hermes and no one send ibc message until timeout time
  • Timeout

New version can collect them.
Here is the case

  • Transfer IBC in EndBlocker
  • Hermes collects event
  • Process IBC messages

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
    • If guide has been updated, tag GitHub user mircea-c
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@kyoodong kyoodong force-pushed the feature/collect_end_block_events branch from 8185f74 to dcaf97a Compare November 29, 2024 10:18
@kyoodong kyoodong closed this Nov 29, 2024
@kyoodong kyoodong reopened this Nov 29, 2024
@kyoodong kyoodong force-pushed the feature/collect_end_block_events branch from 5e5c5a6 to 203490b Compare November 29, 2024 12:09
@kyoodong kyoodong force-pushed the feature/collect_end_block_events branch from c61802c to d932f9c Compare November 29, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant