Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Namada #3705

Open
wants to merge 120 commits into
base: master
Choose a base branch
from
Open

Add support for Namada #3705

wants to merge 120 commits into from

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Nov 21, 2023

Closes: #XXX

Description

To transfer tokens between Namada and Cosmos-base chains.

  • Add Namada to ChainConfig
  • Reuse CosmosSdkConfig for generating Tendermint light clients
  • Add NamadaChain as ChainEndpoint implementation
    • See crates/relayer/src/chain/namada.rs and files under crates/relayer/src/chain/namada
    • To submit Namada transactions and query
  • Store Namada key to KeyRing

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@yito88 yito88 marked this pull request as ready for review November 21, 2023 16:05
@romac romac changed the title Add Namada ChainEndpoint Add support for Namada Jan 18, 2024
ljoss17
ljoss17 reviewed Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits for error upstreaming

crates/relayer/src/chain/namada.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/namada.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/namada.rs Outdated Show resolved Hide resolved
crates/relayer/src/chain/namada.rs Outdated Show resolved Hide resolved
ljoss17
ljoss17 reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some nits.
In addition:

  • For the MSRV, it needs to be updated to v1.79.0 due to [email protected] requires rustc 1.79.0
  • For cargo doc, we can use the stable toolchain instead of nightly-2024-04-21

tools/test-framework/src/bootstrap/namada.rs Outdated Show resolved Hide resolved
tools/test-framework/src/chain/cli/query.rs Outdated Show resolved Hide resolved
tools/test-framework/src/chain/config/namada.rs Outdated Show resolved Hide resolved
tools/test-framework/src/chain/config/namada.rs Outdated Show resolved Hide resolved
tools/test-framework/src/chain/config/namada.rs Outdated Show resolved Hide resolved
tools/test-framework/src/relayer/transfer.rs Outdated Show resolved Hide resolved
crates/relayer-cli/src/commands/keys/add.rs Outdated Show resolved Hide resolved
crates/relayer-cli/src/commands/keys/add.rs Outdated Show resolved Hide resolved
@ljoss17
Copy link
Contributor

ljoss17 commented Nov 26, 2024

Sorry it seems that for cargo doc we need the nightly build, toolchain: nightly-2024-10-15 should work.
For the Rust MSRV we can update cargo msrv to v0.17.1 and remove the -- 'cargo check --all-features' from the CLI call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yito88 @ljoss17 @Fraccaman @tzemanovic