Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert CheckTx errors to ChainError event and remove the latter #2565

Open
romac opened this issue Aug 16, 2022 · 0 comments
Open

Do not convert CheckTx errors to ChainError event and remove the latter #2565

romac opened this issue Aug 16, 2022 · 0 comments
Labels
O: code-hygiene Objective: cause to improve code hygiene
Milestone

Comments

@romac
Copy link
Member

romac commented Aug 16, 2022

With sequential sending, we get the DeliverTX result before sending the next transaction. However it is a bit unclear here whether we should continue submitting the remaining batches to the chain, if DeliverTX or SendTX returns error.

Supposingly, we should probably short circuit and return on the first encounter of error. However I keep the behavior the same as the parallel version, so that we do not observe unexpected difference in behavior when sequential batching is enabled.

The anti-pattern behavior of converting errors to duplicate IBC error events also significantly complicates the design space here. So I'd rather leave the behavior untouched until the chain errors are handled in better ways.

Originally posted by @soareschen in #2543 (comment)

@romac romac added this to the refactor sink milestone Aug 16, 2022
@adizere adizere added the O: code-hygiene Objective: cause to improve code hygiene label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: code-hygiene Objective: cause to improve code hygiene
Projects
None yet
Development

No branches or pull requests

2 participants