Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing failure crate #48

Closed
jgrund opened this issue Feb 13, 2020 · 3 comments · Fixed by #70
Closed

Consider removing failure crate #48

jgrund opened this issue Feb 13, 2020 · 3 comments · Fixed by #70

Comments

@jgrund
Copy link

jgrund commented Feb 13, 2020

Consider removing the failure crate and replace with implementation for std::error::Error and conversions.

@xoac
Copy link

xoac commented Feb 13, 2020

There are crates like thiserror that makes implementation of std::error::Error supper easy

@Empty2k12
Copy link
Collaborator

I'm all in favor of removing dependencies. Feel free to open a pull request!

@qm3ster
Copy link

qm3ster commented Jun 1, 2020

It would not be "removing a dependency" in the strictest sense, but thiserror derives errors that are indistinguishable from manual implementation of std::error::Error trait, and so will not pollute users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants