Skip to content

Conversation

@mnaqvi08
Copy link

Closes #

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed updates to this in pairing, the gist of which is to do the following (which we will confirm with support):

  1. Only subject the ability to open the Contact Support modal to a CLOUD check. If the user is not in a PAYG or Contract account, the user will be notified that they are in a free account, and they must log into a paid account (or upgrade) to proceed further.
  2. Encapsulate the logic for the portion of the modal that is conditionally rendered depending on the user's account state into its own components for readability.
  3. We may (potentially) pipe additional context information (like the organization ID, or general nature of the request -- e.g., 'limit update') into the support modal. We should be able to do that through the Overlay params. Checking with Support on whether they want that (and in what format).

One additional thing to revalidate when this is complete is that everything is still guarded by a CLOUD check, as the modal should only appear in cloud-hosted environments, not OSS.

<p>
To request a series cardinality limit increase, please contact our
support team.
To request a cardinality limit increase, please use the Contact Support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, to simplify the path for the user here, I think we can actually dispatch an action to open the "contact Support" modal here, with the caveat that the Contact Support modal will need to use a Selector function to determine whether the user is in a Free Account, PAYG Account, or Contract Account. This will simplify the path throughout.

)}
/>
{CLOUD && isContractCustomer && (
{CLOUD && (accountType === 'paid' || accountType === 'contract') && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will become a CLOUD check only, and the isContractOrPAYG check will occur within the modal

const isContractOrPAYG = accountType === 'paid' || accountType === 'contract'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants