-
Notifications
You must be signed in to change notification settings - Fork 50
Chore/remove support link references #7106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
wdoconnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed updates to this in pairing, the gist of which is to do the following (which we will confirm with support):
- Only subject the ability to open the Contact Support modal to a
CLOUDcheck. If the user is not in a PAYG or Contract account, the user will be notified that they are in a free account, and they must log into a paid account (or upgrade) to proceed further. - Encapsulate the logic for the portion of the modal that is conditionally rendered depending on the user's account state into its own components for readability.
- We may (potentially) pipe additional context information (like the organization ID, or general nature of the request -- e.g., 'limit update') into the support modal. We should be able to do that through the Overlay params. Checking with Support on whether they want that (and in what format).
One additional thing to revalidate when this is complete is that everything is still guarded by a CLOUD check, as the modal should only appear in cloud-hosted environments, not OSS.
| <p> | ||
| To request a series cardinality limit increase, please contact our | ||
| support team. | ||
| To request a cardinality limit increase, please use the Contact Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, to simplify the path for the user here, I think we can actually dispatch an action to open the "contact Support" modal here, with the caveat that the Contact Support modal will need to use a Selector function to determine whether the user is in a Free Account, PAYG Account, or Contract Account. This will simplify the path throughout.
| )} | ||
| /> | ||
| {CLOUD && isContractCustomer && ( | ||
| {CLOUD && (accountType === 'paid' || accountType === 'contract') && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become a CLOUD check only, and the isContractOrPAYG check will occur within the modal
const isContractOrPAYG = accountType === 'paid' || accountType === 'contract'
Closes #
Checklist
Authors and Reviewer(s), please verify the following: