[Feature Request] diskio input for Darwin

[brettinternet]

Feature Request

Proposal:

Support for diskio input on Darwin

For community discussion, go here: https://community.influxdata.com/t/mac-diskio-input-error-not-implemented-yet/371

Current behavior:

Leaving the default telegraf.conf configuration options on macOS installed with homebrew throws the following error in the log:

E! ERROR in input [inputs.diskio]: error getting disk io info: not implemented yet

Desired behavior:

DiskIO input with Telegraf

Use case:

System stats on a platform as prolific as macOS is essential. This includes an input as critical to Telegraf's purpose as disk IO stats.

Thanks to the InfluxData team, I appreciate all of your excellent support.

[nhaugo]

We get this from gopsutil, which does not provide the data for darwin.

[rburchell]

@nhaugo What are you still missing? I added IO counters for Darwin recently (hoping that telegraf would eventually pick this up)

See shirou/gopsutil#336 for reference.

[danielnelson]

We don't compile with cgo.

[rburchell]

Ah, that's unfortunate. I don't think there's any alternative to get it unfortunately (I did a fair amount of research before settling on that).

[danielnelson]

What I said above is wrong, we don't build for Darwin, so the cgo stuff is up to you. I'm going to update the version of gopsutil for #2649, can you test again after that gets merged?

[rburchell]

Ah, certainly. I guess @brettinternet might be keen to as well ;-). I remember that I installed from Homebrew originally now, I had just sort of forgotten that and thought it was some kind of "official" package.

[rburchell]

Seems to work fine, at least from my (admittedly limited) testing setup :)

[danielnelson]

For the record, I checked into this a bit more and the Homebrew package is official, and built with cgo. Here is the build script. Sorry for the misinformation.

So then it would seem we will have support for this in 1.3.0 and I'm going to close this issue.

[rburchell]

No problems, @danielnelson. Thanks for pulling in the update, I'm thrilled to have this working, and looking forward to 1.3.0 :-)

[rburchell]

@danielnelson Though this came in through an addition to third party code, is it worth adding it to CHANGELOG? I don't know how many there are like me using telegraf on Mac, but it seems reasonably noteworthy.

[danielnelson]

Yeah, probably a good idea, I have added this issue to the changelog.