Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use 5.4.0 #97

Closed
jakoss opened this issue Sep 24, 2021 · 4 comments · Fixed by #98
Closed

Cannot use 5.4.0 #97

jakoss opened this issue Sep 24, 2021 · 4 comments · Fixed by #98
Assignees
Labels
Milestone

Comments

@jakoss
Copy link
Contributor

jakoss commented Sep 24, 2021

✍️ Describe the bug

Trying to use 5.4.0 ends up with:

Execution failed for task ':app:processDebuggableDevDebugResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > Android resource linking failed
     ERROR:C:\Users\Jakub\.gradle\caches\transforms-3\35bca2fadd1db3e7a978d8a5f1446405\transformed\dbinspector-5.4.0\res\values\values.xml:346:5-351:13: AAPT: error: style attribute 'android:attr/windowBlurBehindEnabled' not found.
         
     ERROR:C:\Users\Jakub\.gradle\caches\transforms-3\35bca2fadd1db3e7a978d8a5f1446405\transformed\dbinspector-5.4.0\res\values\values.xml:346:5-351:13: AAPT: error: style attribute 'android:attr/windowBlurBehindRadius' not found.
@bojankoma bojankoma self-assigned this Sep 24, 2021
@bojankoma bojankoma added the bug label Sep 24, 2021
@bojankoma
Copy link
Collaborator

@jakoss Can you help me out here please with more data?
Like SDK versions on the project you are integrating DbInspector with?
5.4.0 is mostly about Android 12 adoption and you are not missing out if you need to use a previous version that works for you.
Until I fix it.

@jakoss
Copy link
Contributor Author

jakoss commented Sep 24, 2021

Sure, i'm targeting and compiling with sdk 30. So i guess it's reasonable that this attribute isn't found. And i'm not sure if this can be managed with backwards compatibility since (AFAIK) there is no androidX library that offers compat attributes for that.

So probably the only thing you can do is to get a warning in documentation stating that 5.4 requires Targeting sdk 31 :)

@bojankoma bojankoma linked a pull request Sep 25, 2021 that will close this issue
@bojankoma
Copy link
Collaborator

@jakoss Thanks, that was helpful. I was able to reproduce it quickly.
You were right, I was way too eager to upgrade and release without proper backwards compatibility support.
I believe following version 5.4.1 has it all fixed, so please try and let me know.

@bojankoma bojankoma added this to the 5.4.1 milestone Sep 25, 2021
@jakoss
Copy link
Contributor Author

jakoss commented Sep 27, 2021

@bojankoma works like a charm now, thanks!

@jakoss jakoss closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants