Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing test for JuMP v1.23.0 #361

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

odow
Copy link
Contributor

@odow odow commented Aug 12, 2024

Fixes a test that will break when jump-dev/JuMP.jl#3799 is released.

Printing tests like this are not very robust to upstream changes, so it's probably best just to paste in the upstream bits and test what you control.

(Sorry for the whitespace changes.)

@odow odow mentioned this pull request Aug 12, 2024
18 tasks
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.25%. Comparing base (9f146c9) to head (93798d1).

Files Patch % Lines
src/TranscriptionOpt/model.jl 85.71% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9f146c9) and HEAD (93798d1). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (9f146c9) HEAD (93798d1)
6 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #361       +/-   ##
===========================================
- Coverage   99.77%   75.25%   -24.53%     
===========================================
  Files          35       32        -3     
  Lines        6750     6705       -45     
===========================================
- Hits         6735     5046     -1689     
- Misses         15     1659     +1644     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsipher
Copy link
Collaborator

Thanks @odow, I am adding on a few more updates such that the docs work with the new printing.

@pulsipher pulsipher merged commit b8b4627 into infiniteopt:master Aug 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants