bn: make .modn() return a BN (fixes #112) #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so I am generally against any breaking changes because I have a lot of modules relying on this and on upgrade I have to upgrade all of them or none of them to avoid conflicting versions of bn (and to avoid having excessive stuff included in browserify bundles). so lets think really hard before doing a major version bump and if we decide we want one we should treat it like the last major version for a long time so make sure we miss nothing. |
|
@calvinmetcalf please see #112 and #129 for more detail |
|
Fixed by introducing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.