chore: remove a bunch of mypy ignores

Author: alexfikl

pytential/source.py

@@ -124,9 +124,9 @@ def get_p2p(self,
         def p2p(target_kernels: tuple[Kernel, ...],
                 source_kernels: tuple[Kernel, ...] | None) -> P2P:
             if any(knl.is_complex_valued for knl in target_kernels):
-                value_dtype = self.complex_dtype    # type: ignore[attr-defined]
+                value_dtype = self.complex_dtype
             else:
-                value_dtype = self.real_dtype       # type: ignore[attr-defined]
+                value_dtype = self.real_dtype
 
             from sumpy.p2p import P2P
             return P2P(actx.context,

pytential/symbolic/dof_desc.py

@@ -183,7 +183,7 @@ def __init__(self,
 
     def copy(self,
             geometry: GeometryId | None = None,
-            discr_stage: DiscretizationStage | None = _NoArgSentinel,  # type: ignore[assignment]
+            discr_stage: DiscretizationStage | None = _NoArgSentinel,
             granularity: DOFGranularity | None = None) -> DOFDescriptor:
         if isinstance(geometry, DOFDescriptor):
             discr_stage = geometry.discr_stage \
@@ -262,7 +262,6 @@ def as_dofdesc(desc: DOFDescriptorLike) -> DOFDescriptor:
         return desc
 
     if desc in (QBX_SOURCE_STAGE1, QBX_SOURCE_STAGE2, QBX_SOURCE_QUAD_STAGE2):
-        # NOTE: mypy is not able to be more specific about the type of `desc`
         return DOFDescriptor(discr_stage=desc)
 
     if desc in (GRANULARITY_NODE, GRANULARITY_CENTER, GRANULARITY_ELEMENT):

pytential/symbolic/mappers.py

@@ -323,11 +323,7 @@ def __init__(self,
         self.default_target: DOFDescriptor = prim.as_dofdesc(default_target)
 
     def map_common_subexpression_uncached(self, expr) -> Expression:
-        # Mypy 1.13 complains about this:
-        # error: Too few arguments for "map_common_subexpression" of "IdentityMapper"  [call-arg]  # noqa: E501
-        # error: Argument 1 to "map_common_subexpression" of "IdentityMapper" has incompatible type "LocationTagger"; expected "IdentityMapper[P]"  [arg-type]  # noqa: E501
-        # This seems spurious?
-        return IdentityMapper.map_common_subexpression(self, expr)  # type: ignore[arg-type, call-arg]
+        return IdentityMapper.map_common_subexpression(self, expr)
 
     def _default_dofdesc(self, dofdesc):
         if dofdesc.geometry is None:

pytential/symbolic/primitives.py

@@ -626,7 +626,7 @@ class IsShapeClass(DiscretizationProperty):
     # FIXME: this is added for backwards compatibility with pre-dataclass expressions
     def __init__(self, shape: mp.Shape, dofdesc: DOFDescriptor) -> None:
         object.__setattr__(self, "shape", shape)
-        super().__init__(dofdesc)  # type: ignore[arg-type]
+        super().__init__(dofdesc)
 
 
 @expr_dataclass()
@@ -648,7 +648,7 @@ def __init__(self,
                  ambient_axis: int,
                  dofdesc: DOFDescriptor) -> None:
         object.__setattr__(self, "ambient_axis", ambient_axis)
-        super().__init__(dofdesc)   # type: ignore[arg-type]
+        super().__init__(dofdesc)
 
 
 def nodes(ambient_dim: int, dofdesc: DOFDescriptorLike = None):
@@ -695,9 +695,7 @@ def __new__(cls,
             def make_op(operand_i):
                 return cls(ref_axes, operand_i, as_dofdesc(dofdesc))
 
-            # FIXME: mypy is right: new should return `cls` instances and we're
-            # abusing it to vectorize the call like this.
-            return componentwise(make_op, operand)  # type: ignore[return-value]
+            return componentwise(make_op, operand)
         else:
             return DiscretizationProperty.__new__(cls)
 
@@ -731,7 +729,7 @@ def __init__(self,
 
         object.__setattr__(self, "ref_axes", ref_axes)
         object.__setattr__(self, "operand", operand)
-        super().__init__(dofdesc)   # type: ignore[arg-type]
+        super().__init__(dofdesc)
 
 
 @for_each_expression
@@ -1363,7 +1361,7 @@ def __new__(cls,
         to_dd = as_dofdesc(to_dd)
 
         if from_dd == to_dd:
-            return operand  # type: ignore[return-value]
+            return operand
 
         if isinstance(operand, np.ndarray | MultiVector):
             warn(f"Passing {type(operand)} directly to {cls.__name__!r} "
@@ -1374,7 +1372,7 @@ def __new__(cls,
             def make_op(operand_i):
                 return cls(from_dd, to_dd, operand_i)
 
-            return componentwise(make_op, operand)  # type: ignore[return-value]
+            return componentwise(make_op, operand)
         else:
             return ExpressionNode.__new__(cls)
 
@@ -1439,7 +1437,7 @@ def __new__(cls,
             def make_op(operand_i):
                 return cls(operand_i)
 
-            return componentwise(make_op, operand)  # type: ignore[return-value]
+            return componentwise(make_op, operand)
         else:
             return ExpressionNode.__new__(cls)
 
@@ -1525,7 +1523,7 @@ def __new__(cls,
             def make_op(operand_i):
                 return cls(operand_i, as_dofdesc(dofdesc))
 
-            return componentwise(make_op, operand)  # type: ignore[return-value]
+            return componentwise(make_op, operand)
         else:
             return ExpressionNode.__new__(cls)
 

pytential/target.py

@@ -110,7 +110,7 @@ def ambient_dim(self) -> int:
     @property
     def ndofs(self) -> int:
         # NOTE: arraycontext.Array is not iterable theoretically
-        for coord_ary in self._nodes:   # type: ignore[attr-defined]
+        for coord_ary in self._nodes:
             return coord_ary.shape[0]
 
         raise AttributeError

test/extra_int_eq_data.py

@@ -365,7 +365,7 @@ class HelmholtzEllisoidTestCase(Helmholtz3DTestCase):
 
     # test case
     resolutions: list[int] = field(
-        default_factory=lambda: [2.0, 0.8])     # type: ignore[list-item]
+        default_factory=lambda: [2.0, 0.8])
     inner_radius: float = 0.4
     outer_radius: float = 5.0
     check_gradient: bool = True
@@ -455,7 +455,7 @@ class GMSHSphereTestCase(SphereTestCase):
 
     radius: float = 1.5
     resolutions: list[int] = field(
-        default_factory=lambda: [0.4])      # type: ignore[list-item]
+        default_factory=lambda: [0.4])
 
     def get_mesh(self, resolution, mesh_order):
         from meshmode.mesh import SimplexElementGroup, TensorProductElementGroup
@@ -531,7 +531,7 @@ class MergedCubesTestCase(Helmholtz3DTestCase):
 
     # test case
     resolutions: list[int] = field(
-        default_factory=lambda: [1.4])  # type: ignore[list-item]
+        default_factory=lambda: [1.4])
     inner_radius: float = 0.4
     outer_radius: float = 12.0
 
@@ -612,7 +612,7 @@ class EllipticPlaneTestCase(IntegralEquationTestCase):
 
     # test case
     resolutions: list[int] = field(
-        default_factory=lambda: [0.1])  # type: ignore[list-item]
+        default_factory=lambda: [0.1])
     inner_radius: float = 0.2
     outer_radius: float = 12   # was '-13' in some large-scale run (?)
     check_gradient: bool = False
@@ -662,7 +662,7 @@ class BetterPlaneTestCase(IntegralEquationTestCase):
 
     # test case
     resolutions: list[int] = field(
-        default_factory=lambda: [0.2])  # type: ignore[list-item]
+        default_factory=lambda: [0.2])
     inner_radius: float = 0.2
     outer_radius: float = 15
     check_gradient: bool = False

test/test_linalg_skeletonization.py

@@ -403,7 +403,7 @@ def test_skeletonize_by_proxy(actx_factory, case, visualize=False):
         extra.GMSHSphereTestCase(
             target_order=8,
             op_type="scalar",
-            resolutions=[0.4]),     # type: ignore[list-item]
+            resolutions=[0.4]),
         ]