Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repr(a) == repr(b) should imply a == b #674

Open
isuruf opened this issue Aug 31, 2022 · 2 comments
Open

repr(a) == repr(b) should imply a == b #674

isuruf opened this issue Aug 31, 2022 · 2 comments

Comments

@isuruf
Copy link
Collaborator

isuruf commented Aug 31, 2022

Currently it is not for TemporaryVariable and Kernel

@inducer
Copy link
Owner

inducer commented Aug 31, 2022

What specifically is missing? Do you have an example or an idea what __repr__ should be doing that it currently isn't?

@isuruf
Copy link
Collaborator Author

isuruf commented Aug 31, 2022

For eg: base_indices is missing from TemporaryVariable's __repr__. There is a bug in privatize_temporaries_with_inames at https://github.com/inducer/loopy/blob/main/loopy/transform/privatize.py#L211 where base_indices is not fixed. I was comparing two TemporaryVariable instances where base_indices was the only difference, but repr on both gave the same string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants