-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitting indi-asi #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work to make this even more modular. Couple of concerns.
install( FILES ${CMAKE_BINARY_DIR}/libASICamera2.so.${ASICAM_VERSION} DESTINATION ${LIB_INSTALL_DIR}${LIB_POSTFIX}) | ||
install( FILES ${CMAKE_BINARY_DIR}/libEFWFilter.so.${ASIEFW_VERSION} DESTINATION ${LIB_INSTALL_DIR}${LIB_POSTFIX}) | ||
install( FILES ${CMAKE_BINARY_DIR}/libUSB2ST4Conv.so.${ASIST4_VERSION} DESTINATION ${LIB_INSTALL_DIR}${LIB_POSTFIX}) | ||
install( FILES ${CMAKE_BINARY_DIR}/libEAFFocuser.so.${ASIEAF_VERSION} DESTINATION ${LIB_INSTALL_DIR}${LIB_POSTFIX}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very important thing that I forgot is that all these files are archive and not shared libraries! So how did you link with them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's interesting. They link without problem during compilation time and the binary works ok. I have tested it on my ASI camera before PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just run ldconfig and it returns "is not an ELF file - it has the wrong magic bytes at the start" for each of these files. Also file returns "current ar archive". What can we do about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe ASI releases both .ar and .so versions.. can you try their latest SDK and see if it resolves this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got SDKs and they provide so files indeed. The problem is that the SDK for ST4 improperly linked on ZWO site so I'm missing this library (USB2ST4_linux_mac_SDK)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I have a copy of the SDK including the shared objects, if that would be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
James, that would be just perfect. Could you drop me an email with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have everything but USB2ST4_linux_mac_SDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be on its way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done. Thanks for the libs James!
INDI driver splited to:
asi-common is obsolete after this change, becoming part of libasi. Debian files have been updated to recognize new dependencies (indi-asi & indi-ssag -> libasi, libasi conflicts and replaces asi-common).
The PR contains minor changes to other debian packaging files for consistency (typos, incorrect dates).