IWF-186: Upgrade Temporal SDK (#442)

Author: lwolczynski

CONTRIBUTING.md

@@ -64,7 +64,9 @@ Or maybe both just for testing to ensure the code works for both Cadence and Tem
 
 ### Option 1: Run with our docker-compose file (Recommended)
 
-Simply run `docker compose -f docker-compose/integ-dependencies.yml up` will:
+Start with shutting down already running dependencies: `docker compose -f docker-compose/integ-dependencies.yml down`
+
+Then simply run `docker compose -f docker-compose/integ-dependencies.yml up`. It will:
 
 * Start both Cadence & Temporal as dependencies
 * Set up required system search attributes
@@ -86,20 +88,20 @@ Assuming you are using `default` namespace:
 1. Make sure you have registered system search attributes required by iWF server
 
 ```shell
-  temporal  operator search-attribute  create -name IwfWorkflowType -type Keyword
-  temporal  operator search-attribute  create -name IwfGlobalWorkflowVersion -type Int 
-  temporal  operator search-attribute  create -name IwfExecutingStateIds -type KeywordList 
+  temporal  operator search-attribute  create --name IwfWorkflowType --type Keyword
+  temporal  operator search-attribute  create --name IwfGlobalWorkflowVersion --type Int 
+  temporal  operator search-attribute  create --name IwfExecutingStateIds --type KeywordList 
 ```
 
 2. For `persistence_test.go` integTests, you need to register below custom search attributes.
 
 ```shell
-  temporal  operator search-attribute  create -name CustomKeywordField -type Keyword
-  temporal  operator search-attribute  create -name CustomIntField -type Int
-  temporal  operator search-attribute  create -name CustomBoolField -type Bool
-  temporal  operator search-attribute  create -name CustomDoubleField -type Double
-  temporal  operator search-attribute  create -name CustomDatetimeField -type Datetime
-  temporal  operator search-attribute  create -name CustomStringField -type Text
+  temporal  operator search-attribute  create --name CustomKeywordField --type Keyword
+  temporal  operator search-attribute  create --name CustomIntField --type Int
+  temporal  operator search-attribute  create --name CustomBoolField --type Bool
+  temporal  operator search-attribute  create --name CustomDoubleField --type Double
+  temporal  operator search-attribute  create --name CustomDatetimeField --type Datetime
+  temporal  operator search-attribute  create --name CustomStringField --type Text
 ```
 
 3. If you run into any issues with Search Attributes registration, use the below command to check the existing Search

Makefile

@@ -168,7 +168,7 @@ integTestsTemporalWithCover: # for local debugging
 	$Q go tool cover -func coverage.out -o coverage.out
 
 integTests:
-	$Q go test -v ./integ
+	$Q go test -v ./integ -timeout 15m
 
 temporalIntegTests:
 	$Q go test -v ./integ -cadence=false
@@ -183,10 +183,12 @@ ci-temporal-integ-test:
 	$Q go test -v ./integ  -cover -coverprofile coverage.out -coverpkg ./service/... -search=false -cadence=false -dependencyWaitSeconds=60
 
 ci-all-tests:
-	$Q go test -v ./... -cover -coverprofile coverage.out -coverpkg ./service/...
+ 	# Fails CI when used with -coverprofile flag due to tests that panic; see https://go.dev/doc/build-cover#panicprof
+ 	# $Q go test -v ./... -timeout 15m -cover -coverprofile coverage.out -coverpkg ./service/...
+	$Q go test -v ./... -timeout 15m
 
 integTestsNoSearch:
-	$Q go test -v ./integ -search=false
+	$Q go test -v ./integ -search=false -timeout 15m
 
 stressTestsWithSearch:
 	$Q go test -v ./integ -repeat=10 -intervalMs=100 -searchWaitMs=100 | tee test.log # TODO https://github.com/indeedeng/iwf/issues/134

docker-compose/.env

@@ -2,5 +2,5 @@ CASSANDRA_VERSION=3.11.9
 ELASTICSEARCH_VERSION=7.16.2
 MYSQL_VERSION=8
 POSTGRESQL_VERSION=13
-TEMPORAL_VERSION=1.22.4
-TEMPORAL_UI_VERSION=2.22.3
+TEMPORAL_VERSION=1.25
+TEMPORAL_UI_VERSION=2.31.2

docker-compose/ci-cadence-temporal-dependencies.yml

@@ -33,7 +33,7 @@ services:
       - postgresql
       - elasticsearch
     environment:
-      - DB=postgresql
+      - DB=postgres12
       - DB_PORT=5432
       - POSTGRES_USER=temporal
       - POSTGRES_PWD=temporal

docker-compose/ci-temporal-dependencies.yml

@@ -33,7 +33,7 @@ services:
       - postgresql
       - elasticsearch
     environment:
-      - DB=postgresql
+      - DB=postgres12
       - DB_PORT=5432
       - POSTGRES_USER=temporal
       - POSTGRES_PWD=temporal

docker-compose/docker-compose.yml

@@ -33,7 +33,7 @@ services:
       - postgresql
       - elasticsearch
     environment:
-      - DB=postgresql
+      - DB=postgres12
       - DB_PORT=5432
       - POSTGRES_USER=temporal
       - POSTGRES_PWD=temporal

docker-compose/init-ci-temporal.sh

@@ -12,23 +12,23 @@ fi
 echo "now trying to register iWF system search attributes..."
 for run in {1..120}; do
   sleep 1
-  temporal  operator search-attribute  create -name IwfWorkflowType -type Keyword
+  temporal  operator search-attribute  create --name IwfWorkflowType --type Keyword
   sleep 0.1
-  temporal  operator search-attribute  create -name IwfGlobalWorkflowVersion -type Int
+  temporal  operator search-attribute  create --name IwfGlobalWorkflowVersion --type Int
   sleep 0.1 
-  temporal  operator search-attribute  create -name IwfExecutingStateIds -type KeywordList 
+  temporal  operator search-attribute  create --name IwfExecutingStateIds --type KeywordList
   sleep 0.1
-  temporal  operator search-attribute  create -name CustomKeywordField -type Keyword
+  temporal  operator search-attribute  create --name CustomKeywordField --type Keyword
   sleep 0.1
-  temporal  operator search-attribute  create -name CustomIntField -type Int
+  temporal  operator search-attribute  create --name CustomIntField --type Int
   sleep 0.1
-  temporal  operator search-attribute  create -name CustomBoolField -type Bool
+  temporal  operator search-attribute  create --name CustomBoolField --type Bool
   sleep 0.1
-  temporal  operator search-attribute  create -name CustomDoubleField -type Double
+  temporal  operator search-attribute  create --name CustomDoubleField --type Double
   sleep 0.1
-  temporal  operator search-attribute  create -name CustomDatetimeField -type Datetime
+  temporal  operator search-attribute  create --name CustomDatetimeField --type Datetime
   sleep 0.1
-  temporal  operator search-attribute  create -name CustomStringField -type Text
+  temporal  operator search-attribute  create --name CustomStringField --type Text
   sleep 0.1
 
   if checkExists "IwfWorkflowType" ] && checkExists "IwfGlobalWorkflowVersion" && checkExists "IwfExecutingStateIds" && checkExists "CustomKeywordField" && checkExists "CustomIntField" && checkExists "CustomBoolField" && checkExists "CustomDoubleField" && checkExists "CustomDatetimeField" && checkExists "CustomStringField" ] ; then

docker-compose/init-compose.sh

@@ -13,11 +13,11 @@ echo "now trying to register iWF system search attributes..."
 
 for run in {1..60}; do
   sleep 1
-  temporal  operator search-attribute  create -name IwfWorkflowType -type Keyword
+  temporal  operator search-attribute  create --name IwfWorkflowType --type Keyword
   sleep 0.1
-  temporal  operator search-attribute  create -name IwfGlobalWorkflowVersion -type Int
+  temporal  operator search-attribute  create --name IwfGlobalWorkflowVersion --type Int
   sleep 0.1 
-  temporal  operator search-attribute  create -name IwfExecutingStateIds -type KeywordList 
+  temporal  operator search-attribute  create --name IwfExecutingStateIds --type KeywordList
   sleep 0.1
   if checkExists "IwfWorkflowType" ] && checkExists "IwfGlobalWorkflowVersion" && checkExists "IwfExecutingStateIds" ] ; then
       echo "All search attributes are registered"

docker-compose/integ-dependencies.yml

@@ -33,7 +33,7 @@ services:
       - postgresql
       - elasticsearch
     environment:
-      - DB=postgresql
+      - DB=postgres12
       - DB_PORT=5432
       - POSTGRES_USER=temporal
       - POSTGRES_PWD=temporal

go.mod

@@ -1,16 +1,16 @@
 module github.com/indeedeng/iwf
 
-go 1.19
+go 1.22
 
 require (
 	github.com/gin-gonic/gin v1.9.1
-	github.com/google/uuid v1.3.0
+	github.com/google/uuid v1.6.0
 	github.com/prometheus/client_golang v1.12.1
-	github.com/stretchr/testify v1.8.4
+	github.com/stretchr/testify v1.9.0
 	github.com/uber-go/tally/v4 v4.1.1
 	github.com/uber/cadence-idl v0.0.0-20220713235846-fda89e95df1e
 	github.com/urfave/cli v1.22.5
-	go.temporal.io/sdk v1.25.1
+	go.temporal.io/sdk v1.29.1
 	go.temporal.io/sdk/contrib/tally v0.1.0
 	go.temporal.io/sdk/contrib/tools/workflowcheck v0.0.0-20220331154559-fd0d1eb548eb
 	go.uber.org/cadence v0.17.1-0.20230105221902-f50f452a8eae // pin to pick GetUnhandledSignalNames API
@@ -21,15 +21,17 @@ require (
 
 require (
 	github.com/pkg/errors v0.9.1
-	go.temporal.io/api v1.24.0
+	go.temporal.io/api v1.39.0
 )
 
 require (
-	github.com/grpc-ecosystem/grpc-gateway v1.16.0 // indirect
-	golang.org/x/crypto v0.19.0 // indirect
-	golang.org/x/net v0.21.0 // indirect
-	google.golang.org/genproto/googleapis/api v0.0.0-20230815205213-6bfd019c3878 // indirect
-	google.golang.org/genproto/googleapis/rpc v0.0.0-20230815205213-6bfd019c3878 // indirect
+	github.com/grpc-ecosystem/grpc-gateway/v2 v2.22.0 // indirect
+	github.com/nexus-rpc/sdk-go v0.0.10 // indirect
+	golang.org/x/crypto v0.26.0 // indirect
+	golang.org/x/net v0.28.0 // indirect
+	golang.org/x/sync v0.8.0 // indirect
+	google.golang.org/genproto/googleapis/api v0.0.0-20240827150818-7e3bb234dfed // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20240827150818-7e3bb234dfed // indirect
 )
 
 require (
@@ -39,7 +41,7 @@ require (
 	github.com/benbjohnson/clock v1.1.0 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/bytedance/sonic v1.9.1 // indirect
-	github.com/cespare/xxhash/v2 v2.2.0 // indirect
+	github.com/cespare/xxhash/v2 v2.3.0 // indirect
 	github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311 // indirect
 	github.com/cpuguy83/go-md2man/v2 v2.0.1 // indirect
 	github.com/cristalhq/jwt/v3 v3.1.0 // indirect
@@ -55,9 +57,9 @@ require (
 	github.com/gogo/googleapis v1.4.1 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/gogo/status v1.1.1 // indirect
-	github.com/golang/mock v1.6.0 // indirect
-	github.com/golang/protobuf v1.5.3 // indirect
-	github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect
+	github.com/golang/mock v1.6.0
+	github.com/golang/protobuf v1.5.4 // indirect
+	github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 // indirect
 	github.com/jessevdk/go-flags v1.4.0 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
 	github.com/kisielk/errcheck v1.5.0 // indirect
@@ -77,7 +79,7 @@ require (
 	github.com/prometheus/procfs v0.7.3 // indirect
 	github.com/robfig/cron v1.2.0 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
-	github.com/stretchr/objx v0.5.0 // indirect
+	github.com/stretchr/objx v0.5.2 // indirect
 	github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
 	github.com/twmb/murmur3 v1.1.5 // indirect
 	github.com/uber-go/mapdecode v1.0.0 // indirect
@@ -91,17 +93,16 @@ require (
 	go.uber.org/net/metrics v1.3.0 // indirect
 	go.uber.org/thriftrw v1.29.2 // indirect
 	golang.org/x/arch v0.3.0 // indirect
-	golang.org/x/exp v0.0.0-20230905200255-921286631fa9
+	golang.org/x/exp v0.0.0-20231127185646-65229373498e
 	golang.org/x/exp/typeparams v0.0.0-20220218215828-6cf2b201936e // indirect
 	golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 // indirect
-	golang.org/x/mod v0.12.0 // indirect
-	golang.org/x/sys v0.17.0 // indirect
-	golang.org/x/text v0.14.0 // indirect
+	golang.org/x/mod v0.17.0 // indirect
+	golang.org/x/sys v0.24.0 // indirect
+	golang.org/x/text v0.17.0 // indirect
 	golang.org/x/time v0.3.0 // indirect
-	golang.org/x/tools v0.13.0 // indirect
-	google.golang.org/genproto v0.0.0-20230815205213-6bfd019c3878 // indirect
-	google.golang.org/grpc v1.57.0 // indirect
-	google.golang.org/protobuf v1.31.0 // indirect
+	golang.org/x/tools v0.21.1-0.20240508182429-e35e4ccd0d2d // indirect
+	google.golang.org/grpc v1.66.0 // indirect
+	google.golang.org/protobuf v1.34.2 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	honnef.co/go/tools v0.3.2 // indirect
 )