Skip to content

feat: add skip to contents link #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 20, 2025
Merged

feat: add skip to contents link #81

merged 6 commits into from
Jan 20, 2025

Conversation

greatislander
Copy link
Member

No description provided.

@greatislander greatislander changed the title feat: add skip to contents link (WIP) feat: add skip to contents link Jan 18, 2025
@greatislander greatislander self-assigned this Jan 18, 2025
@greatislander greatislander added the enhancement New feature or request label Jan 18, 2025
@greatislander greatislander added this to the v1.0 milestone Jan 18, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 18, 2025

Deploying inclusive-standards with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae6e77e
Status: ✅  Deploy successful!
Preview URL: https://63a1a9a5.inclusive-standards.pages.dev
Branch Preview URL: https://feat-skip-to-contents.inclusive-standards.pages.dev

View logs

@greatislander greatislander linked an issue Jan 20, 2025 that may be closed by this pull request
@greatislander greatislander marked this pull request as ready for review January 20, 2025 17:30
@greatislander greatislander enabled auto-merge (squash) January 20, 2025 17:31
@greatislander greatislander enabled auto-merge (squash) January 20, 2025 17:31
@chosww
Copy link
Contributor

chosww commented Jan 20, 2025

Thanks @greatislander, Skip to content looks great and works as expected; however, I found it weird that the language selector is skipped by the skip to content. French screen reader users wouldn't be able to understand what's happening before the language is changed to French, and if they happened to interact with skip to content, they won't be able to find the language selector in normal document tab order. Any thoughts about this? @lliskovoi

@lliskovoi
Copy link

@chosww users are not very likely to use a skip to content before they interact with the page for the very first time, since it's a standard and widely used link for screen reader users, they would likely recognize it, move past it to switch the language if they need it, then use it on subsequent pages. Since language would only be switched once, I think it makes more sense to allow users to skip those controls rather than having to navigate through them on each page.

@greatislander greatislander merged commit 37d0dfe into dev Jan 20, 2025
3 checks passed
@greatislander greatislander deleted the feat/skip-to-contents branch January 20, 2025 18:01
This was referenced Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skip to content link
3 participants