Make RateLimitError implement error rather

incident-io · Apr 17, 2024 · 3a8b107 · 3a8b107
1 parent 85875d8
commit 3a8b107
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -38,4 +38,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@537aa1903e5d359d0b27dbc19ddd22c5087f3fbc # v3.2.0
         with:
-          version: v1.48.0
+          version: v1.49.0
diff --git a/misc.go b/misc.go
@@ -77,11 +77,11 @@ type RateLimitedError struct {
 	RetryAfter time.Duration
 }
 
-func (e *RateLimitedError) Error() string {
+func (e RateLimitedError) Error() string {
 	return fmt.Sprintf("slack rate limit exceeded, retry after %s", e.RetryAfter)
 }
 
-func (e *RateLimitedError) Retryable() bool {
+func (e RateLimitedError) Retryable() bool {
 	return true
 }
 

diff --git a/misc_test.go b/misc_test.go
@@ -2,6 +2,7 @@ package slack
 
 import (
 	"context"
+	"errors"
 	"log"
 	"net/http"
 	"net/url"
@@ -104,3 +105,19 @@ func TestRetryable(t *testing.T) {
 		}
 	}
 }
+
+func TestCanUseErrorsAs(t *testing.T) {
+	ok := errors.As(RateLimitedError{}, &RateLimitedError{})
+	if !ok {
+		t.Errorf("cannot convert to RateLimitedError")
+	}
+	ok = errors.As(StatusCodeError{}, &StatusCodeError{})
+	if !ok {
+		t.Errorf("cannot convert to StatusCodeError")
+	}
+	ok = errors.As(SlackError{}, &SlackError{})
+	if !ok {
+		t.Errorf("cannot convert to SlackError")
+	}
+	// no panic means we're good
+}