Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Improving the speed of the material and product attestor #360

Open
matglas opened this issue Sep 24, 2024 · 2 comments
Open
Labels
feature New feature (larger than enhancement)

Comments

@matglas
Copy link
Contributor

matglas commented Sep 24, 2024

Describe the solution you'd like:

When hashing 10000's of files small and big for both material an product it takes time. Currently the hashing is done in serial while parallel hashing thru threads would speed it up.

User value:

The amount of time spend 'extra' to do the attestation in a pipeline goes down.

Expected behavior:

Material and product hashing should be fast and have little impact on the overall pipeline that a witness execution is part of.

Proposed solution:

Implement threading and a worker queue to process files at the speed of the amount of processors available.

Anything else you would like to add:

I have done a test earlier that showed a 10x speed increase.

Testing changes required:

TBD

Documentation changes required:

TBD

@matglas matglas added the feature New feature (larger than enhancement) label Sep 24, 2024
@matglas matglas changed the title [Improvement]: Improving the speed of the material and product attestor [Enhancement]: Improving the speed of the material and product attestor Sep 24, 2024
@adityasaky
Copy link
Member

I have done a test earlier that showed a 10x speed increase.

I thought this seemed familiar! Do you have a link handy to that?

@matglas
Copy link
Contributor Author

matglas commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature (larger than enhancement)
Projects
None yet
Development

No branches or pull requests

2 participants