-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: rescan folder command #9
Comments
Hey @imsnif. I'm trying to implement this feature but i'm stuck exactly at the point which user should press thanks. |
Hey @mhdmhsni - I'm happy to hear you're working on this. So looking at the code, this is indeed a little tricky. The parts we need to re-run are these: As you probably saw on your own, these are two threads that start when the application loads and die when they are done (when the application is loaded). I think the best option would be to move these two out of main.rs into their own struct (maybe something like I think placing the "good first issue" label here was a mistake on my part, since it's a little more complex than I thought. If however you would like to tackle this, I'd be happy to provide you with whatever help I can. |
Thank you @imsnif for the good hints. i knew about the |
Sure thing! Just a recommendation: I imagine this would require quite some restructuring, so feel free to make drafts of the implementation (just hacking something together that works without worrying too much about tests/clean code, etc.) so that I can comment on them early before you've done a huge amount of work on them. :) |
When pressing "r", the app should prompt the user with an "Are you sure?" modal, and then rescan the entire folder. This is good in case the contents of the folder have changed since the app was open and we don't want to exit the app and enter it again.
The text was updated successfully, but these errors were encountered: