Skip to content

Commit 5bda7c0

Browse files
committed
Temporarily disable UI tests
- Too many sporadic errors occlude actual problems; see #400 - These tests will be re-enabled once the big refactor is complete
1 parent 47378f6 commit 5bda7c0

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

.github/workflows/ci.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ jobs:
124124
done
125125
126126
- name: Run clippy
127-
run: ${{ matrix.cargo }} clippy --all-targets --all-features --target ${{ matrix.target }} -- -D warnings
127+
run: ${{ matrix.cargo }} clippy --all-targets --target ${{ matrix.target }} -- -D warnings
128128

129129
- name: Install npcap on Windows
130130
# PRs from other repositories cannot be trusted with repository secrets
@@ -145,7 +145,7 @@ jobs:
145145
env:
146146
# make insta generate new snapshots in CI
147147
INSTA_UPDATE: new
148-
run: ${{ matrix.cargo }} test --all-targets --all-features --target ${{ matrix.target }}
148+
run: ${{ matrix.cargo }} test --all-targets --target ${{ matrix.target }}
149149

150150
- name: Upload snapshots of failed tests
151151
if: ${{ failure() && steps.run_tests.outcome == 'failure' }}

Cargo.toml

+5
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,11 @@ repository = "https://github.com/imsnif/bandwhich"
2020
rust-version = "1.74.0"
2121
description = "Display current network utilization by process, connection and remote IP/hostname"
2222

23+
[features]
24+
default = []
25+
# UI tests temporarily disabled by default, until big refactor is done
26+
ui_test = []
27+
2328
[dependencies]
2429
anyhow = { version = "1.0.82", features = ["backtrace"] }
2530
async-trait = "0.1.80"

src/tests/cases/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
pub mod raw_mode;
22
pub mod test_utils;
3+
#[cfg(feature = "ui_test")]
34
pub mod ui;

src/tests/cases/test_utils.rs

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#![cfg_attr(not(feature = "ui_test"), allow(dead_code))]
2+
13
use std::{
24
collections::HashMap,
35
io::Write,

0 commit comments

Comments
 (0)