Skip to content

Commit 1319437

Browse files
authored
CI: use GitHub API to exempt dependabot from changelog requirement (#378)
* CI: use GitHub API to exempt dependabot from changelog requirement * Write changelog
1 parent 862ede7 commit 1319437

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

.github/workflows/require-changelog-for-PRs.yml

+16-10
Original file line numberDiff line numberDiff line change
@@ -4,28 +4,34 @@ on:
44
pull_request:
55

66
jobs:
7+
get-submitter:
8+
name: Get the username of the PR submitter
9+
runs-on: ubuntu-latest
10+
outputs:
11+
submitter: ${{ steps.get-submitter.outputs.submitter }}
12+
steps:
13+
# cannot use `github.actor`: the triggering commit may be authored by a maintainer
14+
- name: Get PR submitter
15+
id: get-submitter
16+
run: curl -sSfL https://api.github.com/repos/imsnif/bandwhich/pulls/${PR_NUMBER} | jq -r '"submitter=" + .user.login' | tee -a $GITHUB_OUTPUT
17+
718
check-changelog:
819
name: Check for changelog entry
9-
runs-on: ubuntu-latest
10-
# allow dependabot PRs to have no changelog
11-
if: github.actor != 'dependabot[bot]'
20+
needs: get-submitter
1221
env:
1322
PR_NUMBER: ${{ github.event.number }}
23+
PR_SUBMITTER: ${{ needs.get-submitter.outputs.submitter }}
1424
PR_BASE: ${{ github.base_ref }}
25+
runs-on: ubuntu-latest
26+
# allow dependabot PRs to have no changelog
27+
if: ${{ needs.get-submitter.outputs.submitter != 'dependabot[bot]' }}
1528
steps:
1629
- uses: actions/checkout@v4
1730

1831
- name: Fetch PR base
1932
run: git fetch --no-tags --prune --depth=1 origin
2033

21-
# cannot use `github.actor`: the triggering commit may be authored by a maintainer
22-
- name: Get PR submitter
23-
id: get-submitter
24-
run: curl -sSfL https://api.github.com/repos/imsnif/bandwhich/pulls/${PR_NUMBER} | jq -r '"submitter=" + .user.login' | tee -a $GITHUB_OUTPUT
25-
2634
- name: Search for added line in changelog
27-
env:
28-
PR_SUBMITTER: ${{ steps.get-submitter.outputs.submitter }}
2935
run: |
3036
ADDED=$(git diff -U0 "origin/${PR_BASE}" HEAD -- CHANGELOG.md | grep -P '^\+[^\+].+$')
3137
echo "Added lines in CHANGELOG.md:"

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
88

99
## Fixed
1010
* Remove redundant imports #377 - @cyqsimon
11+
* CI: use GitHub API to exempt dependabot from changelog requirement #378 - @cyqsimon
1112

1213
## Added
1314
* CI: include generated assets in release archive #359 - @cyqsimon

0 commit comments

Comments
 (0)