Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some features #69

Closed
sokra opened this issue Jan 22, 2012 · 1 comment
Closed

some features #69

sokra opened this issue Jan 22, 2012 · 1 comment

Comments

@sokra
Copy link

sokra commented Jan 22, 2012

Hi

i have used impress.js for a presentation and added some features. I like to contribute these to the official project, but i have not used github until now. I was able to add the features in my own fork.

The main features added are: Nested steps and Templates. See my readme for more details.

https://github.com/sokra/impress.js
Also see examle at: http://sokra.github.com/impress.js

I would be happy if i could contribute to this great project.

@bartaz
Copy link
Member

bartaz commented Jan 22, 2012

Wow.

Too many features at once :)

Interesting work with nested steps (there were some other guys asking about it in issue #9).

And for the others, I'm not really sure how useful they are:

  • The phi/r coordinates - who will possibly use it? :) I think the whole x,y,z plus rotations around all axis are complicated enough for normal human being :)
  • These 'templates' ... the effects are indeed quite interesting but the whole thing is way to complicated. Effects like these (but quite simpler) can be easily achieved with CSS transforms based on active class on current step.

Basically, the whole code got so complicated I can't understand most of it anymore :)

Thanks for your input. I want to keep impress.js as simple as possible. Your work is quite inspiring, so I may get back to it at some point and see if it fits to my vision of impress. But right now I'd like to focus on core functionality.

Thanks!

@bartaz bartaz closed this as completed Jan 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants