Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default message for 'New offline donation' #6063

Open
Genevieve-K opened this issue Oct 28, 2021 · 0 comments
Open

Default message for 'New offline donation' #6063

Genevieve-K opened this issue Oct 28, 2021 · 0 comments
Labels
keep-fresh "Keep Fresh" issues should not be marked as stale. type: bug Existing functionality is broken

Comments

@Genevieve-K
Copy link
Contributor

Genevieve-K commented Oct 28, 2021

User Story

As a developper, I want to filter the default messages so so that they are more suitable for donation sites in different countries. I cannot change the default message for 'New offline donation'.

Details

The default message alerting the administrator of a 'New offline donation' is the default 'Donation notification' message.

Moreover, as explained in #6065, the get_default_email_message() function uses {$this->config['id']} which is not yet defined when calling the load() function.

Expected Behavior

In class class-new-offline-donation-email.php:
Line 53:
'default_email_message' => ( false !== give_get_option( 'new-offline-donation_email_message' ) ) ? give_get_option( 'new-offline-donation_email_message' ) : give_get_default_donation_notification_email(),
Replace by:
$this->config['default_email_message'] = ( false !== give_get_option( 'new-offline-donation_email_message' ) ) ? give_get_option( 'new-offline-donation_email_message' ) : $this->get_default_email_message();

@Genevieve-K Genevieve-K added the type: bug Existing functionality is broken label Oct 28, 2021
@Genevieve-K Genevieve-K changed the title [Broken functionality] should... Default message for 'New offline donation' Oct 28, 2021
@kjohnson kjohnson added the keep-fresh "Keep Fresh" issues should not be marked as stale. label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-fresh "Keep Fresh" issues should not be marked as stale. type: bug Existing functionality is broken
Projects
None yet
Development

No branches or pull requests

2 participants