Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 348 #352

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Fix issue 348 #352

merged 2 commits into from
Feb 17, 2025

Conversation

carlocorradini
Copy link
Contributor

Fix #348

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 669dc80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Feb 17, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ehoogeveen-medweb
Copy link

When initializing projectPaths (the expression starting from line 399), should the cwd also be set? I noticed it while manually trying to apply this change locally.

@carlocorradini
Copy link
Contributor Author

@ehoogeveen-medweb With respect to version 3.7, that section remains unchanged.
Nonetheless, I believe the whole method works due to a combination of ESLint, the current working directory, and get-tsconfig.

@ehoogeveen-medweb
Copy link

The parser options for typescript-eslint include option tsconfigRootDir, which it says to set when using the project option. Is that / should that be used here (or an equivalent option)? As I read it, the option only matters when running eslint from a directory other than the workspace root.

@carlocorradini
Copy link
Contributor Author

@ehoogeveen-medweb See issue #282

It would be nice to have projectService 😓

@JounQin JounQin added this pull request to the merge queue Feb 17, 2025
Merged via the queue into import-js:master with commit 0c6303d Feb 17, 2025
15 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 19, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.8.0 | 3.8.2 |


## [v3.8.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#382)

##### Patch Changes

-   [#357](import-js/eslint-import-resolver-typescript#357) [`5fd349e`](import-js/eslint-import-resolver-typescript@5fd349e) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update the `tinyglobby` to the latest version to solve performance regressions.


## [v3.8.1](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#381)

##### Patch Changes

-   [#352](import-js/eslint-import-resolver-typescript#352) [`0c6303d`](import-js/eslint-import-resolver-typescript@0c6303d) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Set cwd while resolving tsconfig include
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 21, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.8.0 | 3.8.3 |


## [v3.8.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#383)

##### Patch Changes

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Force tiniglobby to expand dot directories

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update tinyglobby to latest version


## [v3.8.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#382)

##### Patch Changes

-   [#357](import-js/eslint-import-resolver-typescript#357) [`5fd349e`](import-js/eslint-import-resolver-typescript@5fd349e) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update the `tinyglobby` to the latest version to solve performance regressions.


## [v3.8.1](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#381)

##### Patch Changes

-   [#352](import-js/eslint-import-resolver-typescript#352) [`0c6303d`](import-js/eslint-import-resolver-typescript@0c6303d) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Set cwd while resolving tsconfig include
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 21, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.8.0 | 3.8.3 |


## [v3.8.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#383)

##### Patch Changes

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Force tiniglobby to expand dot directories

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update tinyglobby to latest version


## [v3.8.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#382)

##### Patch Changes

-   [#357](import-js/eslint-import-resolver-typescript#357) [`5fd349e`](import-js/eslint-import-resolver-typescript@5fd349e) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update the `tinyglobby` to the latest version to solve performance regressions.


## [v3.8.1](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#381)

##### Patch Changes

-   [#352](import-js/eslint-import-resolver-typescript#352) [`0c6303d`](import-js/eslint-import-resolver-typescript@0c6303d) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Set cwd while resolving tsconfig include
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 22, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.8.0 | 3.8.3 |


## [v3.8.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#383)

##### Patch Changes

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Force tiniglobby to expand dot directories

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update tinyglobby to latest version


## [v3.8.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#382)

##### Patch Changes

-   [#357](import-js/eslint-import-resolver-typescript#357) [`5fd349e`](import-js/eslint-import-resolver-typescript@5fd349e) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update the `tinyglobby` to the latest version to solve performance regressions.


## [v3.8.1](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#381)

##### Patch Changes

-   [#352](import-js/eslint-import-resolver-typescript#352) [`0c6303d`](import-js/eslint-import-resolver-typescript@0c6303d) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Set cwd while resolving tsconfig include
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 23, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.8.0 | 3.8.3 |


## [v3.8.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#383)

##### Patch Changes

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Force tiniglobby to expand dot directories

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update tinyglobby to latest version


## [v3.8.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#382)

##### Patch Changes

-   [#357](import-js/eslint-import-resolver-typescript#357) [`5fd349e`](import-js/eslint-import-resolver-typescript@5fd349e) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update the `tinyglobby` to the latest version to solve performance regressions.


## [v3.8.1](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#381)

##### Patch Changes

-   [#352](import-js/eslint-import-resolver-typescript#352) [`0c6303d`](import-js/eslint-import-resolver-typescript@0c6303d) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Set cwd while resolving tsconfig include
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Feb 26, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 3.8.0 | 3.8.3 |


## [v3.8.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#383)

##### Patch Changes

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Force tiniglobby to expand dot directories

-   [#360](import-js/eslint-import-resolver-typescript#360) [`8192976`](import-js/eslint-import-resolver-typescript@8192976) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update tinyglobby to latest version


## [v3.8.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#382)

##### Patch Changes

-   [#357](import-js/eslint-import-resolver-typescript#357) [`5fd349e`](import-js/eslint-import-resolver-typescript@5fd349e) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Update the `tinyglobby` to the latest version to solve performance regressions.


## [v3.8.1](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#381)

##### Patch Changes

-   [#352](import-js/eslint-import-resolver-typescript#352) [`0c6303d`](import-js/eslint-import-resolver-typescript@0c6303d) Thanks [@carlocorradini](https://github.com/carlocorradini)! - Set cwd while resolving tsconfig include
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Performance issues after updating to 3.8.0
3 participants