Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add protocol versions to "About UniMe" page #267

Merged
merged 5 commits into from
Jul 29, 2024
Merged

refactor: Add protocol versions to "About UniMe" page #267

merged 5 commits into from
Jul 29, 2024

Conversation

maiertech
Copy link
Member

@maiertech maiertech commented Jul 4, 2024 •
edited
Loading

Description of change

List the specs and their versions used in UniMe's about page but only in dev mode.

Links to any relevant issues

Fixes #265.

How the change has been tested

Visual check of the "About UniMe" page (turn dev mode on and off).

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@maiertech maiertech self-assigned this Jul 4, 2024
@maiertech maiertech changed the title Add underlying specs to "About UniMe" page chore: Add underlying specs to "About UniMe" page Jul 4, 2024
@maiertech maiertech changed the title chore: Add underlying specs to "About UniMe" page refactor: Add underlying specs to "About UniMe" page Jul 4, 2024
@maiertech
Copy link
Member Author

Display in dev mode only.

@maiertech maiertech marked this pull request as ready for review July 24, 2024 16:14
nanderstabel
nanderstabel previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@nanderstabel nanderstabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Except that in desktop mode clicking one of the links result in this page:
image

It's really not a big deal since we're the only once using Desktop, but in case it is a quick fix it might be worth it to fix it.

@nanderstabel nanderstabel self-requested a review July 29, 2024 09:12
@nanderstabel
Copy link
Contributor

Looks good! Except that in desktop mode clicking one of the links result in this page: image

It's really not a big deal since we're the only once using Desktop, but in case it is a quick fix it might be worth it to fix it.

this is the corresponding error in my terminal:

/usr/lib/x86_64-linux-gnu/webkit2gtk-4.1/WebKitNetworkProcess: symbol lookup error: /snap/core20/current/lib/x86_64-linux-gnu/libpthread.so.0: undefined symbol: __libc_pthread_init, version GLIBC_PRIVATE

@nanderstabel
Copy link
Contributor

The WebKit issue I encountered is related to my VSCode somehow. After following these instructions the problem was resolved for me.

nanderstabel
nanderstabel previously approved these changes Jul 29, 2024
View reviewed changes
@nanderstabel nanderstabel self-requested a review July 29, 2024 13:58
@maiertech maiertech changed the title refactor: Add underlying specs to "About UniMe" page refactor: Add protocol versions to "About UniMe" page Jul 29, 2024
@maiertech maiertech merged commit 3addabb into dev Jul 29, 2024
3 checks passed
@maiertech maiertech deleted the maiertech/issue265 branch July 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-mader daniel-mader daniel-mader approved these changes

@nanderstabel nanderstabel nanderstabel approved these changes

Assignees

@maiertech maiertech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add protocol versions to "About Me" page
3 participants
@maiertech @nanderstabel @daniel-mader