Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete credential #227

Closed
daniel-mader opened this issue May 9, 2024 · 0 comments · Fixed by #369
Closed

Delete credential #227

daniel-mader opened this issue May 9, 2024 · 0 comments · Fixed by #369
Assignees
Labels
Added A new feature that requires a minor release.

Comments

@daniel-mader
Copy link
Collaborator

daniel-mader commented May 9, 2024

Description

A user should have the possibility to fully remove a credential from their wallet.

While this was not important in the early phases of development and for demo environments, it is now becoming more of an inconvenience during testing not to be able to recreate a flow again.

The user should be prompted with a confirmation screen before the credential is actually removed (this could be turned off in dev mode). In this confirmation screen, the user could be asked if they want to keep the associated history for that credential or if it should also be removed.

Motivation

Required for production release, but would already improve DX in current stage.

Requirements

  1. New action & reducer to trigger removal (parameters: credential_id, remove_history: bool)
  2. UI element ("three dot menu") in credential/badge details to trigger confirmation sheet
  3. New UI element: "confirmation sheet" (switch/checkbox to confirm removal of history)

Open Questions

  • Recoverability? Undo delete? Restore from trash?
  • Batch delete? Delete multiple credentials/badges at once?

Are you planning to contribute this in a PR?

Yes

@daniel-mader daniel-mader added Request Request a feature Added A new feature that requires a minor release. and removed Request Request a feature labels May 9, 2024
@JelleMillenaar JelleMillenaar added this to the UniMe Quick Wins milestone Aug 16, 2024
@daniel-mader daniel-mader self-assigned this Aug 19, 2024
@Oran-Dan Oran-Dan self-assigned this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants