Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERFORMANCE] Slow backup when the backup list is long - mobile app. #99

Closed
alextran1502 opened this issue Apr 1, 2022 · 0 comments · Fixed by #104
Closed

[PERFORMANCE] Slow backup when the backup list is long - mobile app. #99

alextran1502 opened this issue Apr 1, 2022 · 0 comments · Fixed by #104
Assignees
@alextran1502

Comments

@alextran1502
Copy link
Contributor

Performance Problem
Websocket causes slow backup when the backup list is long, due to continuous rerendering of the assets list on the home page.

Suggestion

  1. Stop listening to WebSocket on_upload_success event when navigating to backup_controller_page
  2. Refetch all assets after poping back from backup_controller_page
@alextran1502 alextran1502 self-assigned this Apr 1, 2022
@alextran1502 alextran1502 moved this to Todo in Immich Apr 1, 2022
@alextran1502 alextran1502 moved this from Todo to In Progress in Immich Apr 3, 2022
@alextran1502 alextran1502 linked a pull request Apr 3, 2022 that will close this issue
Optimization/fix slow backup when asset list is long. #104
Merged
Repository owner moved this from In Progress to Done in Immich Apr 3, 2022
@tye-mustafa tye-mustafa mentioned this issue Dec 18, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alextran1502 alextran1502

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimization/fix slow backup when asset list is long. immich-app/immich
1 participant
@alextran1502