Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: linting newline after HTML elements #9392

Open
mmomjian opened this issue May 11, 2024 · 8 comments
Open

dev: linting newline after HTML elements #9392

mmomjian opened this issue May 11, 2024 · 8 comments

Comments

@mmomjian
Copy link
Contributor

mmomjian commented May 11, 2024

The bug

When running npm run format:fix, the following error is not caught.

<details>
<summary>Check if checksums are enabled</summary>
` ` `bash

Should be:

<details>
<summary>Check if checksums are enabled</summary>

` ` `bash

Without a new line after the HTML blocks, the code block is not be rendered properly. Can we add a linting check to make sure that there is a new line after each HTML element?

@mmomjian mmomjian added the bug label May 11, 2024
@mmomjian mmomjian changed the title dev: linting dev: linting newline after HTML elements May 11, 2024
@jrasm91 jrasm91 removed the bug label Aug 12, 2024
@jrasm91
Copy link
Contributor

jrasm91 commented Sep 10, 2024

I tested this and it rendered correctly for me. If you have a specific example that doesn't work let me know and I can take another look.

@jrasm91 jrasm91 closed this as completed Sep 10, 2024
@mmomjian
Copy link
Contributor Author

Still happens for me with the following snippet from the FAQ:

### The immich_model-cache volume takes up a lot of space, what could>

If you installed several models and chose not to use some of them, it>

<details>
<summary>Steps</summary>
` ` `bash

I’m not sure to see if I’m using an old version of the NPM formatter?

@mmomjian
Copy link
Contributor Author

Or did you mean it renders the HTML ok without the new line?

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 10, 2024

Can you attach of screenshot of the before/after with the difference highlighted because I am not sure what I am looking for.

@mmomjian
Copy link
Contributor Author

Looks like it works now #12547 , ty

@mmomjian
Copy link
Contributor Author

mdx-js/mdx#2263

@mmomjian mmomjian reopened this Sep 20, 2024
@danieldietzler
Copy link
Member

@mmomjian why did you open this again?

@mmomjian
Copy link
Contributor Author

mmomjian commented Apr 1, 2025

We first thought it was fixed but then another PR failed with the same linting issue.

It passes linting but it doesn’t actually render properly in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants