Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info panel state (info-opened) is lost when navigating from asset to person #8460

Closed
1 of 3 tasks
seasox opened this issue Apr 2, 2024 · 4 comments · Fixed by #8472
Closed
1 of 3 tasks

Info panel state (info-opened) is lost when navigating from asset to person #8460

seasox opened this issue Apr 2, 2024 · 4 comments · Fixed by #8472
Labels
good first issue Good for newcomers nice to have Nice to have feature

Comments

@seasox
Copy link
Contributor

seasox commented Apr 2, 2024

The bug

When navigating from the asset viewer to a person (by clicking on a face in the info panel), the info-opened local storage state is reset to false. This causes the info panel to be hidden in subsequent asset viewer pages.

The OS that Immich Server is running on

Debian

Version of Immich Server

v1.100.0

Version of Immich Mobile App

v1.100.0

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

#
# WARNING: Make sure to use the docker-compose.yml of the current release:
#
# https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml
#
# The compose file on main may not be compatible with the latest release.
#

name: immich

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    command: ['start.sh', 'immich']
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - .env
    ports:
      - 2283:3001
    depends_on:
      - redis
      - database
    restart: always

  immich-microservices:
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/hardware-transcoding
    #   file: hwaccel.transcoding.yml
    #   service: cpu # set to one of [nvenc, quicksync, rkmpp, vaapi, vaapi-wsl] for accelerated transcoding
    command: ['start.sh', 'microservices']
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - .env
    depends_on:
      - redis
      - database
    restart: always

  immich-machine-learning:
    container_name: immich_machine_learning
    # For hardware acceleration, add one of -[armnn, cuda, openvino] to the image tag.
    # Example tag: ${IMMICH_VERSION:-release}-cuda
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    # extends: # uncomment this section for hardware acceleration - see https://immich.app/docs/features/ml-hardware-acceleration
    #   file: hwaccel.ml.yml
    #   service: cpu # set to one of [armnn, cuda, openvino, openvino-wsl] for accelerated inference - use the `-wsl` version for WSL2 where applicable
    volumes:
      - model-cache:/cache
    env_file:
      - .env
    restart: always

  redis:
    container_name: immich_redis
    image: registry.hub.docker.com/library/redis:6.2-alpine@sha256:51d6c56749a4243096327e3fb964a48ed92254357108449cb6e23999c37773c5
    restart: always

  database:
    container_name: immich_postgres
    image: registry.hub.docker.com/tensorchord/pgvecto-rs:pg14-v0.2.0@sha256:90724186f0a3517cf6914295b5ab410db9ce23190a2d9d0b9dd6463e3fa298f0
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
    volumes:
      - pgdata:/var/lib/postgresql/data
    restart: always

volumes:
  pgdata:
  model-cache:

Your .env content

# You can find documentation for all the supported env variables at https://immich.app/docs/install/environment-variables

# The location where your uploaded files are stored
UPLOAD_LOCATION=./library

# The Immich version to use. You can pin this to a specific version like "v1.71.0"
IMMICH_VERSION=release

# Connection secret for postgres. You should change it to a random password
DB_PASSWORD=postgres

# The values below this line do not need to be changed
###################################################################################
DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_DATABASE_NAME=immich

REDIS_HOSTNAME=immich_redis

Reproduction steps

1. Open an asset with people in it in the asset viewer.
2. Click the "Info" button at the top
3. Open the "Storage" tab in web developer tools, navigate to "Local Storage".
4. Observe that `info-opened` is `true`.
5. Click on a face in the info panel. The `person` view for that face opens.
6. Observe that `info-opened` was toogled to `false`.
...

Additional information

No response

@aviv926
Copy link
Contributor

aviv926 commented Apr 2, 2024

I'm not sure this fits the definition of a bug, maybe like a feature to request.

@diarranouffou
Copy link

  1. Open an asset with people in it in the asset viewer.
  2. Click the "Info" button at the top
  3. Open the "Storage" tab in web developer tools, navigate to "Local Storage".
  4. Observe that info-opened is true.
  5. Click on a face in the info panel. The person view for that face opens.
  6. Observe that info-opened was toogled to false.
    ...

@diarranouffou
Copy link

  1. Open an asset with people in it in the asset viewer.
  2. Click the "Info" button at the top
  3. Open the "Storage" tab in web developer tools, navigate to "Local Storage".
  4. Observe that info-opened is true.
  5. Click on a face in the info panel. The person view for that face opens.
  6. Observe that info-opened was toogled to false.
    ...``

@diarranouffou
Copy link

  1. Open an asset with people in it in the asset viewer.
  2. Click the "Info" button at the top
  3. Open the "Storage" tab in web developer tools, navigate to "Local Storage".
  4. Observe that info-opened is true.
  5. Click on a face in the info panel. The person view for that face opens.
  6. Observe that info-opened was toogled to false.
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers nice to have Nice to have feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants