-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Add support for custom domain names of individual services #647
Comments
You can change the Name of the container, if you set their original name as hastname in your Docker compose file. That's what I did. Like this:
|
When you specify the container's hostname, does the object objection still work? |
Yes, I can search for things like planes etc. |
So while each component ( For example While the app still works, it's still a monolith of things having to be in specific places and be configured at a specific way. I tested removing the I'm happy to get a draft PR going with the goal of ultimately having the capability to deploy every service separately to each other. But would like to discuss this here first, if this is a direction the projects wants to go. This would (at least) require that very Hostname, Port and Path of API's need to be configurable via env vars. @alextran1502 what do you think? Should get something like this going? |
My homelab is running Kubernetes so I'm building a helm chart to deploy Immich. This capability seems like a requirement to allow for k8s deployments. There is no guarantee the services will be on the same host and it would be nice to not be reliant on hardcoded hostnames. |
hey @thefirstofthe300 , this came up while building a helm-chart for immich. We agreed on having hosting community helm-chart at https://github.com/immich-app/immich-charts. You can find my current WIP for the Chart here feel free to contribute. This Issue is currently blocking the Helm-Chart though, as there is also some NGINX rewriting as part of |
Support for this is now merged. |
Feature detail
Currently, Immich is expecting to have every service run with a specific name inside a docker network.
If someone is to change the name of a service in their
docker-compose.yaml
these services would not be able to find each other.I propose to have a set of Environment variables (like
REDIS_HOSTNAME
is used for redis) for every service to configure hostname and/or port for communication between immich servicesPlatform
Server
The text was updated successfully, but these errors were encountered: