Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Merging one unnamed face with one named face should choose the named faces name #6382

Closed
1 of 3 tasks
jhbruhn opened this issue Jan 14, 2024 · 3 comments
Closed
1 of 3 tasks

Comments

@jhbruhn
Copy link

jhbruhn commented Jan 14, 2024

The bug

When merging faces directly from an unnamed faces context menu in the face selection overview, and then choosing to merge with an already existing, named faced, the resulting face is an unnamed face. This is not what I expected, as I would expect the named faces name to be chosen.

The OS that Immich Server is running on

Docker on Synology NAS

Version of Immich Server

1.92.1

Version of Immich Mobile App

?

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

default docker compose

Your .env content

default env

Reproduction steps

1. Have a named face
2. Have an unnamed face
3. Go to face overview
4. Click on unnamed faces context menu and choose "Merge face"
5. Chose your previously created unnamed face
6. The resulting face is an unnamed face

Additional information

No response

@jhbruhn jhbruhn added the bug label Jan 14, 2024
@AngelPone
Copy link
Contributor

Actually, there is a switch you can use to merge the unnamed face to a named face

CleanShot 2024-01-15 at 12 51 28

@jhbruhn
Copy link
Author

jhbruhn commented Jan 15, 2024

That's nice to know, however I think it would make sense for immich to pre-select the named face as the resulting face.

@jrasm91
Copy link
Contributor

jrasm91 commented Sep 9, 2024

The name is now kept on merge.

@jrasm91 jrasm91 closed this as completed Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants