Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android app can not logout after the server IP is changed. #13886

Closed
1 task done
zl6977 opened this issue Nov 2, 2024 · 7 comments · Fixed by #14104
Closed
1 task done

Android app can not logout after the server IP is changed. #13886

zl6977 opened this issue Nov 2, 2024 · 7 comments · Fixed by #14104

Comments

@zl6977
Copy link

zl6977 commented Nov 2, 2024

The bug

Dear maintainers,

I think I found a bug.

The OS that Immich Server is running on

windows

Version of Immich Server

1.119.1

Version of Immich Mobile App

1.119.1

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

The default one.

Your .env content

Not important.

Reproduction steps

  1. Run the server on a host computer using IP-1, suppose it is 192.168.1.100. And set up the Android app with this IP. Everything can work fine.
  2. Change the host's IP to 192.168.1.101 (call it IP-2), and restart immich server in docker. This is quite common if the server's IP is assigned by DHCP service.
  3. Click "Sign out" on the Android app. I expect it should go to the "endpoint input UI", but it does not. After many times "sign out" and clear APP cache, I finally see the "endpoint input UI", but I do not know how I did it.

Relevant log output

No response

Additional information

I guess the "Sign out" process has to interact with the server, but the server is not reachable if the host IP is changed.
I think this process can be optimized so that the "Sign out" can still work even if the server is not reachable. Otherwise, is there a good way to change the endpoint URL?

Thank you in advance.

Tasks

Preview Give feedback
  1. changelog:bugfix 📱mobile
@ThisIsCyreX
Copy link

I had the same issue if the IP changed / was unreachable.
Sign out did nothing at first, no feedback - but after 1-2 minutes the app logged me out. Was some time ago.

@zl6977
Copy link
Author

zl6977 commented Nov 7, 2024

I had the same issue if the IP changed / was unreachable. Sign out did nothing at first, no feedback - but after 1-2 minutes the app logged me out. Was some time ago.

Good to know I am not alone :)

@Eambo
Copy link

Eambo commented Nov 8, 2024

Just wanted to +1, I've recently moved my server and I couldn't log out of the app to log in to the new server. On Android I had to clear all data (essentially wipe the app) to get it to work.

@robajr
Copy link

robajr commented Nov 8, 2024

log included in the duplicate issue: #14022

And repro steps are faster if you just turn off wifi instead of changing IP

@johnstef99
Copy link
Contributor

I just open a PR to fix this issue, seems that the logout request didn't have a timeout.

@zl6977
Copy link
Author

zl6977 commented Nov 12, 2024

I just open a PR to fix this issue, seems that the logout request didn't have a timeout.

Thank you for trying to fix it. Looking forward to the new version.
Should I close this issue now or when the new version is released?

@johnstef99
Copy link
Contributor

Thank you for trying to fix it. Looking forward to the new version. Should I close this issue now or when the new version is released?

I think you should wait to test it your self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants