Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android "back" gesture closes app when watching video #12186

Closed
1 of 3 tasks
Danilado opened this issue Aug 31, 2024 · 10 comments · Fixed by #12221
Closed
1 of 3 tasks

Android "back" gesture closes app when watching video #12186

Danilado opened this issue Aug 31, 2024 · 10 comments · Fixed by #12221

Comments

@Danilado
Copy link

The bug

When watching videos in android app, the "back" gesture closes (or rather minimizes) the app instead of closing the video view.

This doesn't happen with pictures and gif files

The OS that Immich Server is running on

Opensuse Tumbleweed

Version of Immich Server

v1.113.0

Version of Immich Mobile App

1.113.0 build.156

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

I don't think it's relevant

Your .env content

I don't think it's relevant

Reproduction steps

  1. Open video in the android app
  2. Perform "back" gesture
    Expected behavior: video view closes, I return to timeline
    Real behaviour: app minimizee, I return to the desktop

Relevant log output

No response

Additional information

I tried turning different view settings, such as load original image
The behaviour didn't change

The down swipe performs the desired action

@bo0tzz
Copy link
Member

bo0tzz commented Aug 31, 2024

I can't reproduce this, it behaves as expected for me.

@Danilado
Copy link
Author

Weird just tried reinstalling the app both from google play and the releases page
It still closes the app for me

Im using Vivo IQOO Neo 8 phone running Origin OS 4 based on Android 14
I tried changing to navigation buttons in the OS
Pressing the "back" button performs as expected - I return to the timeline from the video

The problem only happens with the gesture.
Guess I have to suffer from using a cheap chineese device

@Danilado
Copy link
Author

Does it log anywhere so I can provide any data?

You can also just close the Issue if you want, as It seems that I am the only person facing it

@alextran1502
Copy link
Contributor

I can reproduce on Samsung S23

@ryanwinter
Copy link

I have the same issue on pixel 6. Swipe back always closes the app.

@NicholasFlamy
Copy link
Member

This might no longer be an issue with #12104. I just enabled predictive back in a debug build and could not reproduce on my Galaxy S22 Android 14.

@Danilado
Copy link
Author

Danilado commented Feb 5, 2025

@NicholasFlamy
The problem was fixed in September 2024...

@NicholasFlamy
Copy link
Member

NicholasFlamy commented Feb 5, 2025

@NicholasFlamy The problem was fixed in September 2024...

This issue was fixed with PR #12221, but that fix disables predictive back gestures entirely. I re-enabled predictive back gestures in a debug build and I did not have this issue. Most likely the change in PR #12104 (merged in December 2024) fixes the root cause.

@Danilado
Copy link
Author

Danilado commented Feb 5, 2025

Makes sense

You should either create a new issue and mention this one or just reopen this one

@NicholasFlamy
Copy link
Member

Makes sense

You should either create a new issue and mention this one or just reopen this one

Yep, I demoed it and posted in the Discord and may open a PR for predictive back gestures soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants