Skip to content

Commit ec32a9e

Browse files
fix: set min values for face detection to reasonable values (#12877)
fix: set min values for face detection to >0
1 parent bcd4164 commit ec32a9e

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

Diff for: mobile/openapi/lib/model/facial_recognition_config.dart

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: open-api/immich-openapi-specs.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -9119,7 +9119,7 @@
91199119
"maxDistance": {
91209120
"format": "double",
91219121
"maximum": 2,
9122-
"minimum": 0,
9122+
"minimum": 0.1,
91239123
"type": "number"
91249124
},
91259125
"minFaces": {
@@ -9129,7 +9129,7 @@
91299129
"minScore": {
91309130
"format": "double",
91319131
"maximum": 1,
9132-
"minimum": 0,
9132+
"minimum": 0.1,
91339133
"type": "number"
91349134
},
91359135
"modelName": {

Diff for: server/src/dtos/model-config.dto.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,14 +27,14 @@ export class DuplicateDetectionConfig extends TaskConfig {
2727

2828
export class FacialRecognitionConfig extends ModelConfig {
2929
@IsNumber()
30-
@Min(0)
30+
@Min(0.1)
3131
@Max(1)
3232
@Type(() => Number)
3333
@ApiProperty({ type: 'number', format: 'double' })
3434
minScore!: number;
3535

3636
@IsNumber()
37-
@Min(0)
37+
@Min(0.1)
3838
@Max(2)
3939
@Type(() => Number)
4040
@ApiProperty({ type: 'number', format: 'double' })

Diff for: web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte

+2-2
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145
desc={$t('admin.machine_learning_min_detection_score_description')}
146146
bind:value={config.machineLearning.facialRecognition.minScore}
147147
step="0.1"
148-
min={0}
148+
min={0.1}
149149
max={1}
150150
disabled={disabled || !config.machineLearning.enabled || !config.machineLearning.facialRecognition.enabled}
151151
isEdited={config.machineLearning.facialRecognition.minScore !==
@@ -158,7 +158,7 @@
158158
desc={$t('admin.machine_learning_max_recognition_distance_description')}
159159
bind:value={config.machineLearning.facialRecognition.maxDistance}
160160
step="0.1"
161-
min={0}
161+
min={0.1}
162162
max={2}
163163
disabled={disabled || !config.machineLearning.enabled || !config.machineLearning.facialRecognition.enabled}
164164
isEdited={config.machineLearning.facialRecognition.maxDistance !==

0 commit comments

Comments
 (0)