Remove old motion photo video assets when a new one is extracted

Author: kaysond

Diff for: server/src/domain/metadata/metadata.service.ts

@@ -354,7 +354,7 @@ export class MetadataService {
   }
 
   private async applyMotionPhotos(asset: AssetEntity, tags: ImmichTags) {
-    if (asset.type !== AssetType.IMAGE || asset.livePhotoVideoId) {
+    if (asset.type !== AssetType.IMAGE) {
       return;
     }
 
@@ -381,7 +381,11 @@ export class MetadataService {
       length = videoOffset;
     }
 
-    if (!length) {
+    if (
+      length === 0 &&
+      tags.MotionPhotoVideo === undefined &&
+      (tags.EmbeddedVideoFile === undefined || tags.EmbeddedVideoType !== 'MotionPhoto_Data')
+    ) {
       return;
     }
 
@@ -392,11 +396,11 @@ export class MetadataService {
       const position = stat.size - length - padding;
       let video: Buffer;
       // Samsung MotionPhoto video extraction
-      // HEIC-encoded
+      //     HEIC-encoded
       if (tags.MotionPhotoVideo) {
         video = await this.repository.extractBinaryTag(asset.originalPath, 'MotionPhotoVideo');
       }
-      // JPEG-encoded; HEIC also contains these tags, so this conditional must come second
+      //     JPEG-encoded; HEIC also contains these tags, so this conditional must come second
       else if (tags.EmbeddedVideoType === 'MotionPhoto_Data' && tags.EmbeddedVideoFile) {
         video = await this.repository.extractBinaryTag(asset.originalPath, 'EmbeddedVideoFile');
       }
@@ -436,6 +440,23 @@ export class MetadataService {
         await this.jobRepository.queue({ name: JobName.METADATA_EXTRACTION, data: { id: motionAsset.id } });
       }
 
+      if (asset.livePhotoVideoId) {
+        const old_asset = await this.assetRepository.getById(asset.livePhotoVideoId);
+        if (old_asset) {
+          try {
+            await this.assetRepository.remove(old_asset);
+            await this.storageRepository.unlink(old_asset.originalPath);
+          } catch (error: Error | any) {
+            this.logger.error(`Failed to remove old asset ${old_asset.originalPath}: ${error}`, error?.stack);
+          }
+          this.logger.log(`Removed old motion photo video asset (${old_asset.id})`);
+        } else {
+          this.logger.warn(
+            `Tried to remove old motion photo video but asset did not exist (${asset.livePhotoVideoId})`,
+          );
+        }
+      }
+
       await this.assetRepository.save({ id: asset.id, livePhotoVideoId: motionAsset.id });
 
       this.logger.debug(`Finished motion photo video extraction (${asset.id})`);