[minor] Preserve insertion order of Sets, fixes #819 #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are already cloning and iterating over the Set. If we go a step further and clear it before iteration, and re-add all children during iteration, we can preserve insertion order.
✅ Deploy Preview for quizzical-lovelace-dcbd6a canceled.
|
mweststrate
approved these changes
Jan 15, 2023
|
Sorry for the late follow up! Changes look legit, will include in the next minor. |
mweststrate
changed the title
|
🎉 This PR is included in version 9.0.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No worries. Thanks for taking the time to review/include it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #819 insertion order is not always preserved when adding to a Set, though according to MDN it should be.
We were already cloning and iterating over the cloned Set anyway in
finalize.If we take it a step further to clear the original Set after cloning and let
finalizePropertyknow it needs to re-add non-draftable children back to the target then we end up rebuilding the Set in it's original order.We then no longer need to delete anything from the Set in
set