Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classes from net.imglib2.img to net.imglib2.ij #20

Closed
wants to merge 1 commit into from
Closed

Move classes from net.imglib2.img to net.imglib2.ij #20

wants to merge 1 commit into from

Conversation

gab1one
Copy link

@gab1one gab1one commented Sep 3, 2018

The packages net.imglib2.img net.imglib2.display.projector and net.imglib2.img.display are already contained in imglib2, therefore they should not be used here. By adding the common ij infix to the package names this is avoided for current and future packages.

The packages  `net.imglib2.img` `net.imglib2.display.projector` and
`net.imglib2.img.display`  are already contained in imglib2, therefore
they should not be used here. By adding the common `ij` infix to the
package names this is avoided for current and future packages.
@tpietzsch
Copy link
Member

I think this is a good idea.

Because this breaks API completely, I think it would be a good opportunity to clean up and revise the package structure in general. For example some of the things in net.imglib2.img are actually Imgs
and could move to subpackage net.imglib2.ij.img instead of just net.imglib2.ij. Etc.

@axtimwalde
Copy link
Member

axtimwalde commented Oct 23, 2018

Is there a new law in town that doesn't allow me to reuse package names across artifacts? I am all in favor of cleaning up and breaking historic stuff where necessary but not with this pull request which doesn't help anything but only satisfies a new arbitrary policy that I haven't subscribed to.

@tpietzsch
Copy link
Member

Java 9 does not allow split packages in different modules.
So planning ahead to eventually modularizing the fiji world, this is a good idea...

@axtimwalde
Copy link
Member

Ah! Thanks for the pointer. Then, this of course makes sense. Java 9 spinnt! But since nobody observed this policy before, shouldn't this be a more concerted effort across all of imglib2?

@tpietzsch
Copy link
Member

Ideally, yes. But it can be done artifact by artifact.

Using artifact names as package prefixes seems to be a reasonable approach. So imglib2-ij goes to net.imglib2.ij. Other artifacts, e.g., imglib2-realtransform and imglib2-cache already follow this approach.

As a PR this is not very useful, I'm closing it and opened issue #25 instead.

@tpietzsch tpietzsch closed this Oct 23, 2018
@tpietzsch
Copy link
Member

One question is what should happen to imglib2 (core) artifact.
Move everything under net.imglib2.core? Or just be careful not reuse any of the package names as artifact names?

@axtimwalde
Copy link
Member

Weird---right? No opinion yet. Probably being careful would be good enough for starters and less disruptive.

@dietzc dietzc changed the title Move classes from net.imglib2.img to net.imbglib2.ij Move classes from net.imglib2.img to net.imglib2.ij Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants