Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlGridData vertical line not showing #92

Closed
josephmangmang opened this issue Oct 21, 2019 · 14 comments
Closed

FlGridData vertical line not showing #92

josephmangmang opened this issue Oct 21, 2019 · 14 comments
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@josephmangmang
Copy link

Hello,
Thank you for the great library.
I found a problem while using this library. Vertical Gridline is not showing using this code:

gridData: FlGridData( show: true, getDrawingHorizontalGridLine: (value) { return FlLine( color: ColorRes.button_border, strokeWidth: 1); }, checkToShowHorizontalGrid: (value) { final val = _maxY / 100; if (value % (val.floor() * 50 / val.floor()) == 0) { return true; } return false; }, getDrawingVerticalGridLine: (value) { return FlLine( color: ColorRes.button_border, strokeWidth: 5); }, checkToShowVerticalGrid: (value) => true, drawHorizontalGrid: true, drawVerticalGrid: true),

This is the result. Only horizontal grid is showing.

Screen-Shot-2019-10-21-at-5-48-12-PM

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 21, 2019

Hi, since 0.3.4 version, we swapped the horizontal and vertical functionalities, maybe this is your problem, check it out.

@imaNNeo imaNNeo added the question Further information is requested label Oct 21, 2019
@imaNNeo
Copy link
Owner

imaNNeo commented Oct 22, 2019

Heloo?

@josephmangmang
Copy link
Author

@imaNNeoFighT I tried switching to 0.3.3. drawVerticalGrid affects Horizontal line. But drawVerticalGrid=true doesn't show the vertical grid.

@josephmangmang
Copy link
Author

josephmangmang commented Oct 23, 2019

Screen-Shot-2019-10-23-at-11-46-02-AM

if drawVerticalGrid=true it should draw the vertical line.(green)
and for drawHorizontalGrid=true it should draw the horizontal line.(blue)

I think it is more clear to use drawHorizontalLine?
drawHorizontalGrid = drawHorizontalLine

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 25, 2019

You are correct, but it is not important to make breaking changes.
I will fix them at a proper time.
Thank you!

@imaNNeo imaNNeo added the enhancement New feature or request label Oct 25, 2019
@josephmangmang
Copy link
Author

Thanks @imaNNeoFighT

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 29, 2019

You're welcome!

@imaNNeo imaNNeo added the good first issue Good for newcomers label Nov 10, 2019
@imaNNeo
Copy link
Owner

imaNNeo commented Dec 12, 2019

Hi there, It has been renamed in 0.6.0.
Thanks for reporting :)

@imaNNeo imaNNeo closed this as completed Dec 12, 2019
@Serty32
Copy link

Serty32 commented Jun 3, 2021

I have the same problem. Version 0.36.1

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 10, 2021

@Serty32 What is your problem exactly?

@Serty32
Copy link

Serty32 commented Jun 10, 2021

@imaNNeoFighT Vertical lines are not visible.

@imaNNeo
Copy link
Owner

imaNNeo commented Jun 10, 2021

Okay got it. we decided to remove the horizontal value concept from the BarChart. That's why we don't show anything.
Feel free to make a new issue to follow up on this decision. I need to understand the use case (Because I think in the barChart the only yAxis is important).

@gottfired
Copy link

I've got a very dense bar chart where vertical lines would help with orientation of matching bottom labels to mapped values. So in my case it would be great to have vertical grid lines even for a bar chart.

@Peazzycole
Copy link

Peazzycole commented Jun 20, 2024

Hey please can I get the flutter code you used to create this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants