Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for SAP UI5 WC 1.0.0-rc.11 please #4

Open
hrstoyanov opened this issue Dec 22, 2020 · 1 comment
Open

Update for SAP UI5 WC 1.0.0-rc.11 please #4

hrstoyanov opened this issue Dec 22, 2020 · 1 comment

Comments

@hrstoyanov
Copy link

hrstoyanov commented Dec 22, 2020

@ilhan007 can you please update this example project for SAP UI5 WC 1.0.0-rc.11 (latest)?
I found the README.md inconsistent with what the actual rollup.config.js is. Also, the bundle.esm.js does not appear to work with SAP UI5 WC 1.0.0-rc.11 and is very different from the extract in README.md shows. Can you add comments inside bundle.esm.js , please. Also, there is no main.esm.js? Also, the package.json dependencies do not appear to be enough?

For example, if I follow the instruction precisely to build up biundle sapui5wc.esm.js and then try:

import {
   ShellBar, SideNavigation, SideNavigationItem, SideNavigationSubItem
}
    from '../lib/sapui5wc.esm.js';

I get:

127.0.0.1/:1 Uncaught TypeError: Failed to resolve module specifier "@ui5/webcomponents/dist/json-imports/i18n.js". Relative references must start with either "/", "./", or "../".
@hrstoyanov
Copy link
Author

@ilhan007 @pskelin
Any chance this gets updated and becomes part of the SAP UI5 wc project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant