Zbranch #14
Open
Zbranch #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you update to v0.1.11 ? I noticed threads kept dropping until I upgraded to v0.1.11 which was released today. |
|
No I'm on 0.1.10+3eab8a7, were threads dropping on this branch? |
|
Threads were dropping with version 0.1.10+2fd4d08. Threads no longer drop with version 0.1.11+8aa1cef |
|
Looks good to me! Could you please squash commits into one (or 2-3) and use a message like "Add tensorboard logging" and I will accept a PL? |
Add debug flag to run in debug mode (useful for gdb) and use logger instead of print.
|
Thanks! Are you planning to change anything or I can merge the PL? |
|
👍 For now not, If I notice something beneficial, we can have another discussion. |
|
Hi, sorry for delays (was busy with the NIPS deadline). I will review asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, added simple logging with tensorboard logger. (no dependencies on tensorflow)
If you want to keep it simple and minimal it's ok to reject :)
training time here is around 10 hours.