Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[req] Add support for removing spurious f-strings #123

Open
ADraginda opened this issue Mar 6, 2022 · 2 comments
Open

[req] Add support for removing spurious f-strings #123

ADraginda opened this issue Mar 6, 2022 · 2 comments
Labels
enhancement New feature or request PR welcome

Comments

@ADraginda
Copy link

I checked out the project because I was hoping it would help from a common issue I run into

F541 f-string is missing placeholders

Would it be reasonable to have flynt strip out the f prefix for these cases?

@ikamensh
Copy link
Owner

ikamensh commented Apr 14, 2022

Hi, thanks for your suggestion. I think it's most important not to get in conflict with some tool like black that might split strings on multiple lines, creating string segments with f but without placeholders. So if such functionality were to be implemented under a special flag, I would not mind at all.

@ikamensh ikamensh added enhancement New feature or request PR welcome labels Apr 14, 2022
@Nodd
Copy link

Nodd commented Mar 2, 2023

You can perfectly have some strings segments as f-strings and others as standard string, so it shouldn't be a problem ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome
Projects
None yet
Development

No branches or pull requests

3 participants