Skip to content

Commit

Permalink
vendoring: try to catch more vendoring issues.
Browse files Browse the repository at this point in the history
At the moment vendor.conf is missing entries for `github.com/tonistiigi/llb-gobuild`
and `github.com/morikuni/aec` due in part because of a combination of
LK4D4/vndr#62 and LK4D4/vndr#63.

The issue vndr#63 (related to lack of `github.com/morikuni/aec`) can be worked
around by removing the vendor directory before rerunning `vndr`, so do so.

Due to vndr#62 the issue with `github.com/tonistiigi/llb-gobuild` cannot be
detected at the moment, but pass `-strict` to `vndr` in anticipation of a fix
there.

Signed-off-by: Ian Campbell <[email protected]>
  • Loading branch information
Ian Campbell committed Mar 8, 2018
1 parent e8dbd3a commit 0d34cce
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion hack/dockerfiles/vendor.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,6 @@ RUN go get -d github.com/LK4D4/vndr \
&& go install ./
WORKDIR /go/src/github.com/moby/buildkit
COPY . .
RUN vndr --verbose
# Remove vendor first to workaround https://github.com/LK4D4/vndr/issues/63.
RUN rm -rf vendor
RUN vndr --verbose --strict

0 comments on commit 0d34cce

Please sign in to comment.