Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm templates reference non-existent value from values file #59

Open
DrDJIng opened this issue Jan 9, 2025 · 2 comments
Open

Helm templates reference non-existent value from values file #59

DrDJIng opened this issue Jan 9, 2025 · 2 comments

Comments

@DrDJIng
Copy link
Contributor

DrDJIng commented Jan 9, 2025 •
edited
Loading

I noticed today that the deployment template references the field Values.deployment.envSecretName.

However this field does not exist in the values file, instead we have envFromSecret which is not referenced anywhere in the templates or helper template that I found.

When adjusting the values file to envSecretName it of course works, but it did require digging around in the template files to figure out the issue.

If you like I can submit a PR for this, as it is a quick fix.
@DrDJIng
Copy link
Contributor Author

DrDJIng commented Jan 9, 2025

There are some other inconsistencies as well, such as for the full name override.

@pvelop pvelop mentioned this issue Feb 27, 2025
Merged
@pvelop
Copy link
Contributor

pvelop commented Feb 27, 2025 •
edited
Loading

I added a PR to address also the issue with "envFromSecret": #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pvelop @DrDJIng