Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Run.remove_solution() #130

Open
glatterf42 opened this issue Nov 14, 2024 · 0 comments
Open

Improve performance of Run.remove_solution() #130

glatterf42 opened this issue Nov 14, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@glatterf42
Copy link
Member

Mainly as a reminder for myself (this is currently an improvement idea for a feature not yet on main, but I don't know if I can address this before the feature gets to main):
#101 (I think) is likely bringing in a function of the sort Run.remove_solution(). If I remember correctly, I implemented this by iterating over all equations and variables etc defined for run x and deleting their levels and marginals (or setting them to 0 or so).
As we heard in this week's performance workshop by @meksor, this kind of iteration is likely slow, so we can probably increase performance of this operation by constructing a query of the sort DELETE equation.data WHERE equation.run__id == x.

@glatterf42 glatterf42 added the enhancement New feature or request label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant