Skip to content

Aspect Ratio generally includes a ':', not a 'x' #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yarmiganosca opened this issue Jun 27, 2022 · 2 comments · Fixed by #161
Closed

Aspect Ratio generally includes a ':', not a 'x' #160

yarmiganosca opened this issue Jun 27, 2022 · 2 comments · Fixed by #161

Comments

@yarmiganosca
Copy link
Contributor

Aspect ratios are generally given as 16:9 or 4:3, not 16x9, at least in my experience (maybe this differs between language contexts). This results in the error messages this gem produces being a little confusing.
@igorkasyanchuk
Copy link
Owner

I'm fine if you can create a PR with this fix. Should be easy to change.

@yarmiganosca
Copy link
Contributor Author

I should be able to put one together tomorrow.

@yarmiganosca yarmiganosca mentioned this issue Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@igorkasyanchuk @yarmiganosca