New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question for inliers score #8

Open

codeslake opened this issue Oct 19, 2018 · 0 comments

codeslake commented Oct 19, 2018 •

edited

Loading

weakalign/train_weak.py

Line 126 in 52505ea

inliers_comp = inliersComposed(matches=corr_aff,

Hi,
First, thank you for sharing your work.

For the line of code attached, why are you passing "corr_aff" for the match?
Shouldn't it be "corr_aff_tps"?

"mask_id" in the loss computation code goes through transformation up to tps.
Wouldn't it be more appropriate to masking it with "corr_aff_tps"?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment