Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using a C hash table library for processing sentinel responses #9

Open
TysonAndre opened this issue Oct 19, 2017 · 0 comments
Open

Comments

@TysonAndre
Copy link

TysonAndre commented Oct 19, 2017

Either that or loop against all of the expected key values and append the matches to corresponding lists, then processing the lists.

Twemproxy currently does the sentinel response processing in a loop; it's highly sensitive to order, and hardcodes assumptions about how many lines there are.

https://github.com/attractivechaos/klib (MIT) may be promising; I haven't worked with it before.

this would prevent bugs similar to the following:

#8
#6

Even #6 continues to assume lines will be in the expected order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant