Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid server_failure_limit - heartbeat interacts with it poorly? #49

Open
TysonAndre opened this issue May 7, 2021 · 0 comments
Open

Comments

@TysonAndre
Copy link

src/nc_server.c server_failure will call add_failed_server without calling server_pool_run(which updates the distribution) for a failed server. It will set server->fail to a different value, though, and if ketama_update does get called by something else then that will remove the server from the pool.

The whole point of the heartbeat patch seems to be to avoid sending requests to failed servers, so server_failure_limit may be unnecessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant