Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client crashes if app adds any functions to Array.prototype (or Object.prototype) #5

Open
yankov opened this issue May 12, 2012 · 0 comments

Comments

@yankov
Copy link

yankov commented May 12, 2012

Code to reproduce

Array.prototype.include = function(value) {};

var kafka = require('kafka')

new kafka.Consumer().connect().subscribeTopic('juggernaut')
console.log("Consumed message:", message)
})

Throws

TypeError: Cannot read property 'length' of undefined
at [object Object]._encodeFetchRequest (/Users/yankov/ruby/fix/node_modules/kafka/lib/Client.js:99:26)
at [object Object]. (/Users/yankov/ruby/fix/node_modules/kafka/lib/Client.js:33:16)
at Object.encode (native)
at [object Object]._writeRequest (/Users/yankov/ruby/fix/node_modules/kafka/lib/Client.js:94:55)
at [object Object]._onConnect (/Users/yankov/ruby/fix/node_modules/kafka/lib/Client.js:85:34)
at Socket.bound (/Users/yankov/ruby/fix/node_modules/kafka/node_modules/std/bind.js:47:17)
at Socket.emit (events.js:81:20)
at Socket._onConnect (net.js:588:12)
at IOWatcher.onWritable as callback

It looks like when iterating topics it gets functions from Array for some reason and then tries to threat them as real topics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant