From 6653b075695968e5e3b591f63df54fcb72ff7121 Mon Sep 17 00:00:00 2001 From: Geremia Taglialatela Date: Fri, 17 Jan 2025 08:56:35 +0100 Subject: [PATCH] Fix unsafe offenses in production code (#11) --- .rubocop_todo.yml | 27 +-------------------------- Rakefile | 2 ++ lib/colore-client.rb | 2 ++ lib/colore/client.rb | 4 +++- lib/colore/client/version.rb | 2 ++ lib/colore/errors.rb | 2 ++ 6 files changed, 12 insertions(+), 27 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0f65b3f..6955249 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -8,7 +8,7 @@ # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: - Max: 35 + Max: 34 # Configuration parameters: CountComments, CountAsOne. Metrics/ClassLength: @@ -37,28 +37,3 @@ Style/Documentation: - 'test/**/*' - 'lib/colore/client.rb' - 'lib/colore/errors.rb' - -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: always, always_true, never -Style/FrozenStringLiteralComment: - Exclude: - - 'Rakefile' - - 'lib/colore-client.rb' - - 'lib/colore/client.rb' - - 'lib/colore/client/version.rb' - - 'lib/colore/errors.rb' - -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: EnforcedStyle. -# SupportedStyles: literals, strict -Style/MutableConstant: - Exclude: - - 'lib/colore/client.rb' - - 'lib/colore/client/version.rb' - -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: AllowedCompactTypes. -# SupportedStyles: compact, exploded -Style/RaiseArgs: - EnforcedStyle: compact diff --git a/Rakefile b/Rakefile index 5e6a5f3..54a27b0 100644 --- a/Rakefile +++ b/Rakefile @@ -1,3 +1,5 @@ +# frozen_string_literal: true + # Bundler require 'bundler/setup' diff --git a/lib/colore-client.rb b/lib/colore-client.rb index cb20c98..996813d 100644 --- a/lib/colore-client.rb +++ b/lib/colore-client.rb @@ -1,2 +1,4 @@ +# frozen_string_literal: true + require_relative 'colore/errors' require_relative 'colore/client' diff --git a/lib/colore/client.rb b/lib/colore/client.rb index a63c98d..4af92af 100644 --- a/lib/colore/client.rb +++ b/lib/colore/client.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'faraday' require 'json' require 'logger' @@ -240,7 +242,7 @@ def send_request(type, path, params = {}, expect = :binary) raise error rescue Faraday::ConnectionFailed - raise Errors::ColoreUnavailable.new + raise Errors::ColoreUnavailable end private diff --git a/lib/colore/client/version.rb b/lib/colore/client/version.rb index 317ef11..6c8d5d7 100644 --- a/lib/colore/client/version.rb +++ b/lib/colore/client/version.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Colore class Client VERSION = '1.0.0' diff --git a/lib/colore/errors.rb b/lib/colore/errors.rb index 695bca6..7c0e6de 100644 --- a/lib/colore/errors.rb +++ b/lib/colore/errors.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Colore module Errors class ColoreUnavailable < StandardError